Skip to content

ERC20 burn lacks balance check #996

New issue
New issue
Closed
Closed
ERC20 burn lacks balance check#996
Assignees
sandrawillow001-afk
Labels
Stellar WaveIssues in the Stellar wave program

Description

@DevMuhdishaq
DevMuhdishaq
opened on Oct 12, 2026

Problem

The chart library integration in components/PerformanceChart.tsx uses deprecated recharts versions without proper TypeScript type definitions, causing type errors and missing features in the chart visualizations.

Why it matters

Deprecated chart library:

  1. TypeScript type errors and compilation failures
  2. Missing chart features (animations, tooltips, responsive design)
  3. Inconsistent chart appearance across the application
  4. Security vulnerabilities in outdated library versions

Suggested Direction

  1. Upgrade recharts to the latest version or migrate to chart.js or visx.
  2. Add proper TypeScript type definitions for the chart library.
  3. Add responsive chart dimensions and breakpoint support.
  4. Add accessible chart alternatives (text descriptions, data tables).
  5. Write a test asserting the charts render correctly with proper types.
  6. Check components/MetricsOverview.tsx and components/TimeSeriesChart.tsx for the same chart library gaps.

Acceptance Criteria

  • Chart library is updated to latest version or migrated to modern alternative
  • TypeScript type definitions are proper and error-free
  • Charts are responsive and work across screen sizes
  • Accessible chart alternatives provided (data tables, descriptions)
  • Test asserts charts render correctly with proper types
  • No deprecated chart library versions remain in the codebase
  • All chart components use consistent library and types

Related

components/PerformanceChart.tsx, components/MetricsOverview.tsx, components/TimeSeriesChart.tsx, package.json, test/Chart.test.ts

Activity

  1. shobhamerabacha-star commented on Oct 12, 2026

    @shobhamerabacha-star
    shobhamerabacha-star
    on Oct 12, 2026

    Greetings,

    I looked into the details for "ERC20 burn lacks balance check" and would like to contribute the fix.

    Technical Implementation Outline:

    1. Review contract state storage keys, TTL policies, and auth guards (Address::require_auth).
    2. Implement safe state transition logic with checked arithmetic preventing under/overflow.
    3. Write comprehensive Soroban unit tests covering standard flows, unauthorized callers, and reverts.
    4. Verify contract execution footprint passes Soroban CPU/memory budget limits.

    Please assign this issue to me. I will submit a clean, well-tested, and production-ready PR promptly!

  2. drips-wave
    added
    Stellar WaveIssues in the Stellar wave program
    on Oct 19, 2026

  3. DanProtocol commented on Oct 19, 2026

    @DanProtocol
    DanProtocol
    on Oct 19, 2026 – with Drips Wave

    @DanProtocol has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    Hi Maintainer, I’d like to take this issue if it’s still available. I’ve reviewed the details and understand the expected changes. I can jump into it immediately and aim to get a working PR up within the next few hours.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @DanProtocol to this issue.

  4. davidsoniaudin2-oss commented on Oct 19, 2026

    @davidsoniaudin2-oss
    davidsoniaudin2-oss
    on Oct 19, 2026 – with Drips Wave

    @davidsoniaudin2-oss has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    sir i can work on this issue sir

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @davidsoniaudin2-oss to this issue.

  5. sandrawillow001-afk commented on Oct 19, 2026

    @sandrawillow001-afk
    sandrawillow001-afk
    on Oct 19, 2026 – with Drips Wave
    Contributor

    @sandrawillow001-afk has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    sir i can work on this issue sir

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @sandrawillow001-afk to this issue.

  6. DevMuhdishaq
    assigned
    sandrawillow001-afk
    on Oct 19, 2026

  7. drips-wave commented on Oct 19, 2026

    @drips-wave
    drips-waveBot
    on Oct 19, 2026 – with Drips Wave

    Congratulations, @sandrawillow001-afk! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @sandrawillow001-afk: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  8. sandrawillow001-afk commented on Oct 21, 2026

    @sandrawillow001-afk
    sandrawillow001-afk
    on Oct 21, 2026
    Contributor

    Not applicable to this repository: there is no chart library at all — recharts, chart.js and visx are absent from package.json, and there are no PerformanceChart/MetricsOverview/TimeSeriesChart components to upgrade or migrate. Adding a chart stack so this issue has a file to point at would be new feature work, not a fix, so I left it out of #1048.

  9. ayshadogo
    closed this as completedon Oct 26, 2026

  10. drips-wave commented on Oct 26, 2026

    @drips-wave
    drips-waveBot
    on Oct 26, 2026 – with Drips Wave

    This issue has been completed by @sandrawillow001-afk as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @sandrawillow001-afk: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions