fix(refresh): preserve article selection while refreshing - #1052
Draft
marcomarcogd wants to merge 1 commit into
Draft
fix(refresh): preserve article selection while refreshing#1052marcomarcogd wants to merge 1 commit into
marcomarcogd wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Keeps the currently open article available while a background feed refresh replaces the first article page. This prevents the article list from flashing empty and the detail pane from becoming blank when the selected article is not present in the refreshed first page.
Type of Change
Related Issues
Fixes #874
Changes Made
Testing
Test Configuration
mainTest Steps
NODE_OPTIONS=--localstorage-file=/private/tmp/mrrss-vitest-874-localstorage npm test -- --run src/App.test.tsnpm run lintnpm run buildgit diff --checkAll targeted checks pass.
Checklist
Breaking Changes
None.