Loadout CSV: Fill Artifact Season/Unlocks columns with new artifact info where possible - #11966
Open
FlaminSarge wants to merge 3 commits into
Open
Loadout CSV: Fill Artifact Season/Unlocks columns with new artifact info where possible#11966FlaminSarge wants to merge 3 commits into
FlaminSarge wants to merge 3 commits into
Conversation
…bclass or artifact
…act Season' column and equipped mods in existing 'Artifact Unlocks' columns
FlaminSarge
commented
Sep 8, 2026
Comment on lines
+173
to
183
| 'Artifact Season': | ||
| artifact?.item.name || loadout.parameters?.artifactUnlocks?.seasonNumber || '', | ||
| 'Artifact Unlocks': ( | ||
| artifact?.item.sockets?.allSockets?.map( | ||
| (s) => artifact?.loadoutItem.socketOverrides?.[s.socketIndex] || 0, | ||
| ) || | ||
| loadout.parameters?.artifactUnlocks?.unlockedItemHashes || | ||
| [] | ||
| ).map( | ||
| (modHash) => (modHash && defs.InventoryItem.get(modHash)?.displayProperties.name) || '', | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
This might end up creating empty-value columns where previously it would omit the columns if none of the loadouts had the column available. I don't know if that's permissible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also update the text on shared loadouts to indicate that socket overrides could be subclass or artifact
Also fixes an issue where share sheet would show incorrect mod counts
Changelog: Loadout CSV export now handles new artifacts
Related: DestinyItemManager/dim-api#316
Recreation of #11962