only keep known fields on imported shared loadouts - #11961
Open
dxbjavid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a shared loadout link is fully attacker-controlled json, and convertDimApiLoadoutToLoadout spreads every top-level key it carries straight into the loadout we store and later sync to dim sync, so a crafted ?loadout= link (or dim.gg share) can smuggle arbitrary unmodelled fields past the import boundary. preprocessReceivedLoadout only clamped the stat constraints, so it now rebuilds the received loadout from just the fields a loadout is allowed to have, reusing the same newLoadout construction the url-parameters path already uses. added a small test covering an injected extra key.