Repository navigation
chore: update mcp latest version to 2.3.0 - #19447
dd-octo-sts[bot] wants to merge 1 commit into
Conversation
Circular import analysis
|
Codeowners resolved asResolved from the full PR diff against |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e81ee7ebac
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| jsonschema==4.26.0 | ||
| jsonschema-specifications==2025.9.1 | ||
| mcp==1.28.1 | ||
| mcp==2.0.0 |
There was a problem hiding this comment.
Keep MCP latest below v2 until the integration is migrated
Locking the latest MCP venvs to 2.0.0 makes this suite install SDK v2, but the integration is still written against v1 internals: patch() imports and wraps mcp.shared.session.BaseSession, and the tests still use create_connected_server_and_client_session; the MCP v2 migration guide lists both as removed. In any venv using this lockfile (and the identical latest MCP lockfiles), the autouse setup calls patch() and will fail before the tests run, and users on MCP 2 won't get instrumentation, so please keep the latest constraint below 2 or migrate the patch/tests before advertising 2.0.0 support.
Useful? React with 👍 / 👎.
❌ ErrorsYour PR has failed checks. Please review the issues below and take necessary action before merging. 🚦 2 Pipeline jobs failed
ℹ️ InfoNo other issues found (see more)🧪 All tests passed Useful? React with 👍 / 👎 This comment will be updated automatically if new data arrives.🔗 Commit SHA: ecff024 | Docs | View more details | Give us feedback! |
BenchmarksBenchmark execution time: 2026-10-07 01:23:49 Comparing candidate commit ecff024 in PR branch Found 0 performance improvements and 9 performance regressions! Performance is the same for 590 metrics, 10 unstable metrics, 7 known flaky benchmarks, 17 flaky benchmarks without significant changes.
|
e81ee7e to
a6c4f83
Compare
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
a6c4f83 to
20390e3
Compare
Dependency direction analysis
|
| try: | ||
| llmobs_context_provider = integration._get_llmobs_context_provider() | ||
| previous_llmobs_context = llmobs_context_provider.active() if llmobs_context_provider else None | ||
| tracer.context_provider.activate(None) |
There was a problem hiding this comment.
Might be missing something here, mcp 1.x kept the server spans nested under the ambient context and this detaches them into their own traces. Is there something about MCP that needs the clear?
|
Converted to draft because prechecks are failing |
cafbb6b to
ecff024
Compare
Update mcp lockfiles and dependency package lockfiles.
This performs the following updates:
latest. This updates that package and its dependencies.