Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ package com.datadog.android.core.internal.time
import android.os.Process
import com.datadog.android.internal.system.BuildSdkVersionProvider
import com.datadog.android.internal.time.TimeProvider
import com.datadog.android.internal.utils.guardedProcessStartNs
import com.datadog.android.rum.DdRumContentProvider
import java.util.concurrent.TimeUnit
import kotlin.time.Duration.Companion.seconds
Expand All @@ -22,28 +23,18 @@ internal class DefaultAppStartTimeProvider(
when {
buildSdkVersionProvider.isAtLeastN -> {
val timeProvider = timeProviderFactory()
// Uses the uptime clock (excludes device sleep time) to measure the gap between
// process start and now, then back-projects to an elapsed-time nanosecond value.
// See AppLaunchPreInitCollector.computeProcessStartNs() for the parallel impl that
// uses the elapsedRealtime clock instead (required when storing System.nanoTime()).
val diffMs = timeProvider.getDeviceUptimeMillis() - Process.getStartUptimeMillis()
val computedAppStartTimeNs =
val computed =
timeProvider.getDeviceElapsedTimeNanos() - TimeUnit.MILLISECONDS.toNanos(diffMs)
val contentProviderCreateTimeNs = DdRumContentProvider.createTimeNs
val isAfterContentProviderInit = computedAppStartTimeNs > contentProviderCreateTimeNs
val isTooFarBeforeContentProviderInit =
contentProviderCreateTimeNs - computedAppStartTimeNs >
PROCESS_START_TO_CP_START_DIFF_THRESHOLD_NS

/**
* Guard against unexpected values from [Process.getStartUptimeMillis].
* Two directions are checked and fall back to [DdRumContentProvider] creation time:
* - computedAppStartTimeNs > createTimeNs: app start appears to be after content provider init,
* which is impossible.
* - computedAppStartTimeNs is more than the threshold before createTimeNs: app start appears
* unreasonably far in the past.
*/
if (isAfterContentProviderInit || isTooFarBeforeContentProviderInit) {
contentProviderCreateTimeNs
} else {
computedAppStartTimeNs
}
guardedProcessStartNs(
computed = computed,
fallback = DdRumContentProvider.createTimeNs,
thresholdNs = PROCESS_START_TO_CP_START_DIFF_THRESHOLD_NS
)
}
else -> DdRumContentProvider.createTimeNs
}
Expand Down
37 changes: 37 additions & 0 deletions dd-sdk-android-internal/api/apiSurface
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ val NULL_MAP_VALUE: Object
fun Int.toHexString(): String
fun Long.toHexString(): String
fun java.math.BigInteger.toHexString(): String
fun guardedProcessStartNs(Long, Long, Long): Long
fun <T> allowThreadDiskReads(() -> T): T
fun <T> allowThreadDiskWrites(() -> T): T
fun StringBuilder.appendIfNotEmpty(String)
Expand All @@ -315,6 +316,23 @@ fun Thread.State.asString(): String
fun Array<StackTraceElement>.loggableStackTrace(): String
fun Throwable.loggableStackTrace(): String
fun formatIsoUtc(Long): String
object com.datadog.android.rum.AppLaunchPreInitCollector
enum State
- NOT_INSTALLED
- IDLE
- CAPTURING
- COMPLETE
- CLAIMED
val state: State
var processStartNs: Long
var activityOnCreateNs: Long
var firstFrameNs: Long
var hasSavedInstanceState: Boolean
var isFirstActivityForProcess: Boolean
var activity: java.lang.ref.WeakReference<android.app.Activity>?
fun install(android.app.Application)
fun claim(): Boolean
fun addFirstFrameCallback((Long) -> Unit)
class com.datadog.android.rum.DdRumContentProvider : android.content.ContentProvider
override fun onCreate(): Boolean
override fun query(android.net.Uri, Array<String>?, String?, Array<String>?, String?): android.database.Cursor?
Expand All @@ -325,5 +343,24 @@ class com.datadog.android.rum.DdRumContentProvider : android.content.ContentProv
companion object
var processImportance: Int
var createTimeNs: Long
interface com.datadog.android.rum.startup.RumFirstDrawTimeReporter
interface Handle
fun unsubscribe()
interface Callback
fun onFirstFrameDrawn(Long)
fun subscribeToFirstFrameDrawn(android.app.Activity, Callback): Handle
class com.datadog.android.rum.startup.RumFirstDrawTimeReporterImpl : RumFirstDrawTimeReporter
constructor(() -> Long, WindowCallbacksRegistry, android.os.Handler, String = "DD/AppLaunch", (String) -> Unit = { message, throwable ->
Log.w(logTag, message, throwable)
})
override fun subscribeToFirstFrameDrawn(android.app.Activity, RumFirstDrawTimeReporter.Callback): RumFirstDrawTimeReporter.Handle
interface com.datadog.android.rum.startup.WindowCallbackListener
fun onContentChanged()
interface com.datadog.android.rum.startup.WindowCallbacksRegistry
fun addListener(android.app.Activity, WindowCallbackListener)
fun removeListener(android.app.Activity, WindowCallbackListener)
class com.datadog.android.rum.startup.WindowCallbacksRegistryImpl : WindowCallbacksRegistry
override fun addListener(android.app.Activity, WindowCallbackListener)
override fun removeListener(android.app.Activity, WindowCallbackListener)
annotation com.datadog.tools.annotation.NoOpImplementation
constructor(Boolean = false, String = "")
67 changes: 67 additions & 0 deletions dd-sdk-android-internal/api/dd-sdk-android-internal.api
Original file line number Diff line number Diff line change
Expand Up @@ -756,6 +756,10 @@ public final class com/datadog/android/internal/utils/NumberExtKt {
public static final fun toHexString (Ljava/math/BigInteger;)Ljava/lang/String;
}

public final class com/datadog/android/internal/utils/ProcessStartUtilsKt {
public static final fun guardedProcessStartNs (JJJ)J
}

public final class com/datadog/android/internal/utils/StrictModeExtKt {
public static final fun allowThreadDiskReads (Lkotlin/jvm/functions/Function0;)Ljava/lang/Object;
public static final fun allowThreadDiskWrites (Lkotlin/jvm/functions/Function0;)Ljava/lang/Object;
Expand Down Expand Up @@ -789,6 +793,36 @@ public final class com/datadog/android/internal/utils/TimeExtKt {
public static final fun formatIsoUtc (J)Ljava/lang/String;
}

public final class com/datadog/android/rum/AppLaunchPreInitCollector {
public static final field INSTANCE Lcom/datadog/android/rum/AppLaunchPreInitCollector;
public final fun addFirstFrameCallback (Lkotlin/jvm/functions/Function1;)V
public final fun claim ()Z
public final fun getActivity ()Ljava/lang/ref/WeakReference;
public final fun getActivityOnCreateNs ()J
public final fun getFirstFrameNs ()J
public final fun getHasSavedInstanceState ()Z
public final fun getProcessStartNs ()J
public final fun getState ()Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public final fun install (Landroid/app/Application;)V
public final fun isFirstActivityForProcess ()Z
public final fun setActivity (Ljava/lang/ref/WeakReference;)V
public final fun setActivityOnCreateNs (J)V
public final fun setFirstActivityForProcess (Z)V
public final fun setFirstFrameNs (J)V
public final fun setHasSavedInstanceState (Z)V
public final fun setProcessStartNs (J)V
}

public final class com/datadog/android/rum/AppLaunchPreInitCollector$State : java/lang/Enum {
public static final field CAPTURING Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public static final field CLAIMED Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public static final field COMPLETE Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public static final field IDLE Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public static final field NOT_INSTALLED Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public static fun valueOf (Ljava/lang/String;)Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
public static fun values ()[Lcom/datadog/android/rum/AppLaunchPreInitCollector$State;
}

public final class com/datadog/android/rum/DdRumContentProvider : android/content/ContentProvider {
public static final field Companion Lcom/datadog/android/rum/DdRumContentProvider$Companion;
public fun <init> ()V
Expand All @@ -807,6 +841,39 @@ public final class com/datadog/android/rum/DdRumContentProvider$Companion {
public final fun setProcessImportance (I)V
}

public abstract interface class com/datadog/android/rum/startup/RumFirstDrawTimeReporter {
public abstract fun subscribeToFirstFrameDrawn (Landroid/app/Activity;Lcom/datadog/android/rum/startup/RumFirstDrawTimeReporter$Callback;)Lcom/datadog/android/rum/startup/RumFirstDrawTimeReporter$Handle;
}

public abstract interface class com/datadog/android/rum/startup/RumFirstDrawTimeReporter$Callback {
public abstract fun onFirstFrameDrawn (J)V
}

public abstract interface class com/datadog/android/rum/startup/RumFirstDrawTimeReporter$Handle {
public abstract fun unsubscribe ()V
}

public final class com/datadog/android/rum/startup/RumFirstDrawTimeReporterImpl : com/datadog/android/rum/startup/RumFirstDrawTimeReporter {
public fun <init> (Lkotlin/jvm/functions/Function0;Lcom/datadog/android/rum/startup/WindowCallbacksRegistry;Landroid/os/Handler;Ljava/lang/String;Lkotlin/jvm/functions/Function2;)V
public synthetic fun <init> (Lkotlin/jvm/functions/Function0;Lcom/datadog/android/rum/startup/WindowCallbacksRegistry;Landroid/os/Handler;Ljava/lang/String;Lkotlin/jvm/functions/Function2;ILkotlin/jvm/internal/DefaultConstructorMarker;)V
public fun subscribeToFirstFrameDrawn (Landroid/app/Activity;Lcom/datadog/android/rum/startup/RumFirstDrawTimeReporter$Callback;)Lcom/datadog/android/rum/startup/RumFirstDrawTimeReporter$Handle;
}

public abstract interface class com/datadog/android/rum/startup/WindowCallbackListener {
public abstract fun onContentChanged ()V
}

public abstract interface class com/datadog/android/rum/startup/WindowCallbacksRegistry {
public abstract fun addListener (Landroid/app/Activity;Lcom/datadog/android/rum/startup/WindowCallbackListener;)V
public abstract fun removeListener (Landroid/app/Activity;Lcom/datadog/android/rum/startup/WindowCallbackListener;)V
}

public final class com/datadog/android/rum/startup/WindowCallbacksRegistryImpl : com/datadog/android/rum/startup/WindowCallbacksRegistry {
public fun <init> ()V
public fun addListener (Landroid/app/Activity;Lcom/datadog/android/rum/startup/WindowCallbackListener;)V
public fun removeListener (Landroid/app/Activity;Lcom/datadog/android/rum/startup/WindowCallbackListener;)V
}

public abstract interface annotation class com/datadog/tools/annotation/NoOpImplementation : java/lang/annotation/Annotation {
public abstract fun customName ()Ljava/lang/String;
public abstract fun publicNoOpImplementation ()Z
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
/*
* Unless explicitly stated otherwise all files in this repository are licensed under the Apache License Version 2.0.
* This product includes software developed at Datadog (https://www.datadoghq.com/).
* Copyright 2016-Present Datadog, Inc.
*/

package com.datadog.android.internal.utils

/**
* Returns [computed] if it falls within a plausible range relative to [fallback]; otherwise
* returns [fallback].
*
* Two failure modes are guarded:
* - computed > fallback → impossible (process started after the reference point)
* - fallback - computed > thresholdNs → unreasonably far in the past (OEM clock bug)
*/
fun guardedProcessStartNs(computed: Long, fallback: Long, thresholdNs: Long): Long =
if (computed > fallback || fallback - computed > thresholdNs) fallback else computed
Loading
Loading