Skip to content

Further debug missing cache files - #5561

Merged
adamnovak merged 3 commits into
masterfrom
issues/5084-debug-missing-cache-files
Aug 13, 2026
Merged

Further debug missing cache files#5561
adamnovak merged 3 commits into
masterfrom
issues/5084-debug-missing-cache-files

Conversation

@adamnovak

@adamnovak adamnovak commented Aug 6, 2026

Copy link
Copy Markdown
Member

Changelog Entry

To be copied to the draft changelog by merger:

  • Toil now correctly accesses the database when complaining that files have gone missing from its cache.
  • Toil no longer deletes files uploaded with writeGlobalFile when a job finishes with the caching file store.

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passed tests, including the Gitlab tests, for the most recent commit in its branch.
  • Make sure the PR has been reviewed. If not, review it. If it has been reviewed and any requested changes seem to have been addressed, proceed.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

@adamnovak

adamnovak commented Aug 6, 2026

Copy link
Copy Markdown
Member Author

This will fix #5562 by no longer deleting files that have been uploaded to a CachingFileStore from wherever they were uploaded from when the job finishes. If the files were in the temp directory for the job, they'll get deleted when we clean that up, and if they weren't, they aren't our responsibility.

@adamnovak

Copy link
Copy Markdown
Member Author

I'm not sure this will actually do anything about #5084. I don't see how the delete-all-the-ref-files step I am removing could have resulted in files missing from the actual cache (except maybe by broken symlink?).

@adamnovak
adamnovak merged commit 4c63eb3 into master Aug 13, 2026
3 checks passed
@adamnovak
adamnovak deleted the issues/5084-debug-missing-cache-files branch August 13, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

WDL call cache can end up with copies of input files (and steal the originals) when they pass through cached tasks

1 participant