This repository was archived by the owner on Apr 25, 2020. It is now read-only.
[WIP] New cabal helper used in hie - #947
Open
alanz wants to merge 53 commits into
Open
Conversation
This is because when a component makes use of another internal one, the modules are added to the options. This then mismatches the cabal file representation, but is not an error in the cabal file for normal compilation.
- Add ModuleLoader to ghc-mod-core This it to enable integration of tooling using ghc-mod-core into haskell-ide-engine, making use of a shared session and artifact cache. - Remove FileUri and replace with FilePath - Replace useless Monad constraint with MonadIO - Removed extensible state - Bump haskell-src-exts upper bound - Update for current dev cabal-helper - Moved code from ghc-mod-core ModuleLoader.hs back into hie - Bump haskell-src-exts upper bound
Needs matching update in cabal-helper
- Add cabal-helper local copy - Remove redundant packages, bump haskell-src-exts upper bound - Relax various upper bounds
- As djinn-ghc is not updated. - Update for hie integration
- Refactor splits and split' to reduce duplicate code - Make performSplit less partial - Fix error in determining SplitResult source locations. - Accommodate AST change in 8.4.1 - Fix typo in GHC version check
- Canonicalize mapped path also - Fix compilation with GHC 8.4.3
i.e. all GHC stuff is qualified with G.
And cabal-helper-1.0.0
Since ghc-mod goes to a lot of trouble to work out the environment all by itself.
They are still needed for plain projects, without stack or cabal files
To avoid boolean blindness
But I gather it needs an upate to Cabal, coming soon.
Since it bales on presence of dist*
Which is not used by hie ...
For some definition of works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR exists purely to document that I am working on this, and there is no expectation that it will actually get merged.
cc @DanielG