Skip to content

refactor: 패키지 구조 통일 및 미사용 설정 정리 (#29) - #30

Open
cowtree28 wants to merge 2 commits into
developfrom
feature/29-unify-package-structure
Open

refactor: 패키지 구조 통일 및 미사용 설정 정리 (#29)#30
cowtree28 wants to merge 2 commits into
developfrom
feature/29-unify-package-structure

Conversation

@cowtree28

@cowtree28 cowtree28 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Summary

  • 도메인 패키지 구조가 두 가지 컨벤션으로 나뉘어 있던 것을 하나로 통일하였습니다.
  • 아무 코드도 읽지 않는 garage.* 설정을 application.yaml에서 제거하였습니다.

Related Issue

Scope

  • 포함 범위: domain/auth·admin·user·petitioner → auth/·admin/·user/·petitioner/ 최상위 도메인 이동, presentation→controller·domain→entity/repository 하위 구조 통일(human/certificate/file과 동일), garage 설정 제거
  • 제외 범위: 클래스 내용/동작 변경 없음 (패키지 선언과 import만 변경), human·certificate·file 도메인은 변경 없음

Implementation

  • git mv로 파일 이동 후 패키지 선언·import 일괄 치환
  • 엔티티 테이블명은 어노테이션 기반(@table 등)이라 스키마 영향 없음
  • 변경 전후 전체 테스트(36건) 통과로 동작 동일함을 확인

Testing

  • 단위 테스트
  • 통합 테스트
  • 수동 검증
  • 기존 테스트 전체 통과 (컴파일 + CI)

Deployment Notes

Checklist

  • 제품 및 기술 요구사항 충족
  • 하위 호환성 고려 완료
  • 해당 시 문서 업데이트 완료

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Refactor

    • Reorganized authentication, administration, user, petitioner, and certificate components into a clearer package structure.
    • Consolidated related request and response models under their respective controller areas.
    • Added centralized administration role definitions.
    • Updated supporting security and repository integrations without changing behavior.
  • Chores

    • Removed obsolete storage configuration.
    • Preserved existing login, signup, account, password, and user-management functionality.

cowtree28 and others added 2 commits August 27, 2026 13:41
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 27, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c2561305-49f9-4636-af79-479a07bba55c

📥 Commits

Reviewing files that changed from the base of the PR and between 04b3a66 and 7150e71.

📒 Files selected for processing (36)
  • src/main/java/commonly/commonlybe/admin/controller/AdminController.java
  • src/main/java/commonly/commonlybe/admin/controller/dto/ChangeInitialPasswordRequest.java
  • src/main/java/commonly/commonlybe/admin/controller/dto/CreateUserRequest.java
  • src/main/java/commonly/commonlybe/admin/controller/dto/UserListResponse.java
  • src/main/java/commonly/commonlybe/admin/entity/Admin.java
  • src/main/java/commonly/commonlybe/admin/entity/AdminRole.java
  • src/main/java/commonly/commonlybe/admin/repository/AdminRepository.java
  • src/main/java/commonly/commonlybe/admin/service/ChangeInitialPasswordService.java
  • src/main/java/commonly/commonlybe/admin/service/CreateUserService.java
  • src/main/java/commonly/commonlybe/admin/service/DeleteUserService.java
  • src/main/java/commonly/commonlybe/admin/service/QueryUserListService.java
  • src/main/java/commonly/commonlybe/auth/controller/AuthController.java
  • src/main/java/commonly/commonlybe/auth/controller/dto/ChangePasswordRequest.java
  • src/main/java/commonly/commonlybe/auth/controller/dto/LoginRequest.java
  • src/main/java/commonly/commonlybe/auth/controller/dto/SignupRequest.java
  • src/main/java/commonly/commonlybe/auth/controller/dto/TokenResponse.java
  • src/main/java/commonly/commonlybe/auth/controller/dto/UpdateAccountRequest.java
  • src/main/java/commonly/commonlybe/auth/service/ChangePasswordService.java
  • src/main/java/commonly/commonlybe/auth/service/LoginService.java
  • src/main/java/commonly/commonlybe/auth/service/SignupService.java
  • src/main/java/commonly/commonlybe/auth/service/UpdateAccountService.java
  • src/main/java/commonly/commonlybe/certificate/service/PetitionerHumanResolver.java
  • src/main/java/commonly/commonlybe/domain/admin/domain/AdminRole.java
  • src/main/java/commonly/commonlybe/global/jwt/JwtParser.java
  • src/main/java/commonly/commonlybe/global/security/auth/AuthDetails.java
  • src/main/java/commonly/commonlybe/global/security/auth/AuthDetailsService.java
  • src/main/java/commonly/commonlybe/petitioner/entity/Petitioner.java
  • src/main/java/commonly/commonlybe/petitioner/repository/PetitionerRepository.java
  • src/main/java/commonly/commonlybe/user/entity/User.java
  • src/main/java/commonly/commonlybe/user/exception/ForbiddenUserException.java
  • src/main/java/commonly/commonlybe/user/exception/PasswordMismatchException.java
  • src/main/java/commonly/commonlybe/user/exception/UserAlreadyExistsException.java
  • src/main/java/commonly/commonlybe/user/exception/UserErrorCode.java
  • src/main/java/commonly/commonlybe/user/exception/UserNotFoundException.java
  • src/main/java/commonly/commonlybe/user/repository/UserRepository.java
  • src/main/resources/application.yaml
💤 Files with no reviewable changes (2)
  • src/main/java/commonly/commonlybe/domain/admin/domain/AdminRole.java
  • src/main/resources/application.yaml

Included review availability: Your plan provides up to 10 included reviews per hour; 4 remain after this review.


📝 Walkthrough

Walkthrough

The change standardizes authentication, administration, user, and petitioner packages under top-level domain structures. It updates related imports without changing runtime behavior and removes unused garage configuration.

Changes

Package structure unification

Layer / File(s) Summary
Core domain types and repositories
src/main/java/commonly/commonlybe/{admin,petitioner,user}/...
Moves entities, repositories, exceptions, and role definitions to the reorganized packages.
Administration controllers and services
src/main/java/commonly/commonlybe/admin/...
Updates administration DTOs, controller wiring, repository imports, and user-management service imports.
Authentication controllers and services
src/main/java/commonly/commonlybe/auth/...
Moves authentication DTOs and updates controller and service imports.
Integration imports and configuration cleanup
src/main/java/commonly/commonlybe/{certificate,global}/..., src/main/resources/application.yaml
Updates certificate and security imports and removes the unused garage configuration block.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 7150e

This PR standardizes package locations and removes unused configuration without intended behavior changes. No actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the package structure refactor and removal of unused configuration. It matches the primary changes.
Linked Issues check ✅ Passed The changes satisfy issue #29. They standardize the auth, admin, user, and petitioner packages, preserve behavior, and remove the unused application.yaml garage.* configuration.
Out of Scope Changes check ✅ Passed The changes are within scope. Updates to dependent imports, AdminRole relocation, and PetitionerHumanResolver are necessary for the package restructure. No unrelated behavior or deployment changes are…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Full details: Out of Scope Changes check

Explanation

The changes are within scope. Updates to dependent imports, AdminRole relocation, and PetitionerHumanResolver are necessary for the package restructure. No unrelated behavior or deployment changes are shown.

Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 34 files.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/29-unify-package-structure

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

패키지 구조 통일 및 미사용 설정 정리

1 participant