Skip to content

feat (#16) :: 로그인 페이지 퍼블리싱 - #17

Merged
hxm2n merged 5 commits into
mainfrom
feature/#16-auth-login-publishing
Aug 17, 2026
Merged

feat (#16) :: 로그인 페이지 퍼블리싱#17
hxm2n merged 5 commits into
mainfrom
feature/#16-auth-login-publishing

Conversation

@hxm2n

@hxm2n hxm2n commented Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • 학생/선생님 로그인 화면 퍼블리싱
  • 비밀번호 보기/숨기기 아이콘 전환 및 역할 전환 애니메이션 추가
  • 미리보기 홈과 dev component preview 제거 후 /login 진입으로 전환

Review

  • 직접 코드 리뷰 결과: blocking finding 없음
  • 독립 subagent 리뷰 레인은 현재 Codex App tool policy상 미사용

Verification

  • corepack pnpm lint
  • corepack pnpm build
  • corepack pnpm exec tsc --noEmit
  • corepack pnpm exec playwright test tests/e2e/auth-login.spec.ts tests/e2e/public-routes.spec.ts
  • Manual QA: / -> /login redirect, password toggle, teacher switch, console errors none

hxm2n added 5 commits July 11, 2026 22:36
Constraint: pnpm 설치 산출물은 저장소 변경에 섞이지 않아야 함

Confidence: high

Scope-risk: narrow

Tested: git diff --staged --stat

Not-tested: runtime behavior unaffected
Constraint: 로그인 퍼블리싱은 기존 shared UI를 우선 재사용해야 함

Confidence: high

Scope-risk: narrow

Tested: git diff --staged --stat

Not-tested: full verification runs after split commits
Constraint: 첨부 시안 기준 퍼블리싱과 역할 전환 애니메이션을 먼저 제공

Confidence: high

Scope-risk: moderate

Tested: tests/e2e/auth-login.spec.ts added; full verification runs after split commits

Not-tested: real authentication API integration
Constraint: 로그인 페이지가 서비스 진입점이 되면서 데모 홈과 dev preview route를 제거

Confidence: high

Scope-risk: moderate

Tested: public route smoke updated; full verification runs after split commits

Not-tested: production deployment
Constraint: GitHub Actions fresh runner에는 Playwright browser cache가 없음

Confidence: high

Scope-risk: narrow

Tested: git diff --check

Not-tested: GitHub Actions rerun before push
@hxm2n
hxm2n merged commit d270296 into main Aug 17, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant