Feature/#14 example components - #15
Merged
Merged
Conversation
Constraint: Issue #14 focuses on Figma-derived shared components, not API/editor/PDF integration. Rejected: Variant-heavy card/sheet APIs | Current Figma contract is fixed and premature abstraction would widen scope. Confidence: high Scope-risk: moderate Directive: Treat LibraryBookCard cover asset and PortfolioResumeSheet typography as issue #14 fixed contracts until design/API scope expands. Refs: #14 Tested: pnpm test:unit; pnpm lint; pnpm build; pnpm test:e2e; git diff --check Not-tested: Real API data, student editor interactions, PDF rendering/export
Constraint: Issue #14 focuses on Figma-derived shared components, not API/editor/PDF integration. Rejected: Variant-heavy card/sheet APIs | Current Figma contract is fixed and premature abstraction would widen scope. Confidence: high Scope-risk: moderate Directive: Treat LibraryBookCard cover asset and PortfolioResumeSheet typography as issue #14 fixed contracts until design/API scope expands. Refs: #14 Tested: pnpm test:unit; pnpm lint; pnpm build; pnpm test:e2e; git diff --check Not-tested: Real API data, student editor interactions, PDF rendering/export
…into feature/#14-example-components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.