[Infra]: Playwright E2E baseline 구축 - #13
Merged
Merged
Conversation
Constraint: Playwright route smoke tests must run against production-equivalent Next start without adding product UI scope.\nRejected: Browser-based smoke tests | Route status and SSR content checks do not require browser binaries yet.\nConfidence: high\nScope-risk: narrow\nDirective: Keep this PR limited to test infrastructure and route smoke coverage; defer auth UI, dropdown a11y, and route policy abstraction.\nTested: pnpm lint; pnpm build; pnpm test:e2e; git diff --check\nNot-tested: GitHub Actions execution before PR checks run remotely
Constraint: PR review flagged exact Node version stability and missing minimal workflow permissions.\nRejected: Keeping exact 20.20.2 in CI | setup-node should track valid Node 20 releases reliably.\nConfidence: high\nScope-risk: narrow\nDirective: Keep Playwright webServer build ownership single-sourced in CI; do not expand this PR into product UI work.\nTested: pnpm lint; pnpm build; pnpm test:e2e; git diff --check\nNot-tested: None
Collaborator
Author
Code Review Summary\n\n최종 독립 리뷰 결과입니다.\n\n- code-reviewer recommendation: APPROVE\n- architect status: CLEAR\n- final recommendation: APPROVE\n\n검증 evidence:\n-
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
요약
next start서버 기준 route smoke test를 추가했습니다.포함 범위
@playwright/testdevDependency 추가playwright.config.ts추가pnpm test:e2escript 추가/,/오혜민,/dev,/dev/component-previewsmoke test 추가제외 범위
검증
pnpm lintpnpm buildpnpm test:e2egit diff --checkCloses #12