Skip to content

Fix: generate form accessiblity - #612

Merged
rinnaaza merged 41 commits into
stagingfrom
fix/generate-form-accessiblity
Nov 18, 2026
Merged

rinnaaza merged 41 commits into
stagingfrom
fix/generate-form-accessiblity

Conversation

@rinnaaza

@rinnaaza rinnaaza commented Nov 17, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Fix accessibility of edit and new forms, fix some heading hierarchy and mobile responsiveness

Ticket(s) notion associé(s)

Liste de vérification

  • J'ai testé mes modifications localement
  • Les tests automatisés passent avec succès
  • J'ai ajouté des tests pour couvrir mes modifications / Mes modifications n'impactent pas les tests
  • J'ai mis à jour la documentation si nécessaire
  • J'ai vérifié l'accessibilité de mes modifications

rinnaaza and others added 29 commits November 17, 2026 16:07
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…nibles et titre de page dynamique

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ux fieldsets

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…dsets avec légende

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… champs texte

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chaque groupe oui/non de « Avez-vous réussi à joindre l'administration ? »
est un fieldset dont la légende reprend la question (fr-sr-only) et le
moyen de contact, au lieu d'un label orphelin.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rmulaire

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ernative textuelle

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Les étapes ne sont pas des liens : on reprend le balisage du SideMenu DSFR
avec un bouton par élément de liste, dans une navigation nommée.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seul l'input reste désactivé ; le badge « option masquée » est conservé.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Menu des étapes et contenu en colonne pleine largeur sur mobile, boutons
d'en-tête sous les titres pour que leurs icônes restent dans le bouton.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tion et consigne

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
aria-invalid, aria-describedby vers les messages d'info et d'erreur, et
focus sur le message d'erreur à la soumission.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ibilité

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bouton « Étapes du formulaire » / « Cacher les étapes » piloté en React,
style de la maquette une fois déplié, sans soulignement, pleine largeur.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…sous le libellé sur mobile

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r mobile

En-têtes, actions des blocs, navigation entre étapes et boutons de l'éditeur
passent en colonne ; contenu de l'étape en pleine largeur avec 16px d'espacement.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… à la ligne si besoin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…latéral

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rinnaaza rinnaaza changed the title Fix/generate form accessiblity Fix: generate form accessiblity Nov 17, 2026
@rinnaaza
rinnaaza changed the base branch from main to staging November 17, 2026 15:12
rinnaaza and others added 10 commits November 17, 2026 16:46
Fixed ids (question-commentaire, consigne-email...) collided when a form had several comment or email blocks. Use question-{block.id} and consigne-{block.id} for every block.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every paragraph editor was labelled "Texte d'introduction". Point aria-labelledby at the block heading instead.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use the option's alt_text from the database and fall back to the style mapping.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The form title is an h4, so the alert heading becomes an h5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A label only accepts phrasing content.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…tyles

Move the disabled-label contrast rule and the mobile hidden badge style to sharedStyles instead of copying them in Checkboxes, Radios and the new form page.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… on blur

Pass react-hook-form's ref to the input so it focuses the invalid field on submit, instead of moving focus to the error text. Replace the page-level watch with a title committed on blur, to avoid re-rendering the page on every keystroke.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The row label was not linked to any control; the fieldset legend already names the radios.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use && to override the DSFR gutter padding on the column.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Remove the negative margins from FormStepDisplay and FormStepper and cancel the page gutter once on the configurator column, with no padding on mobile.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dan1M and others added 2 commits November 18, 2026 15:35
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rinnaaza rinnaaza self-assigned this Nov 18, 2026
@rinnaaza
rinnaaza merged commit 40930da into staging Nov 18, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants