[NPQ-3930] EHCO journeys - #3551
Open
alkesh wants to merge 1 commit into
Open
Conversation
alkesh
changed the base branch from
main
to
NPQ-3873-previous-funding-after-login
August 11, 2026 10:31
Contributor
|
Review app deployed to https://npq-registration-review-3551-web.test.teacherservices.cloud/ |
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 11, 2026 10:48
8e4ab31 to
a00e65f
Compare
Contributor
|
Review app for PR 3551 was deleted |
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 13, 2026 15:10
f55bfc3 to
078409d
Compare
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 13, 2026 16:07
078409d to
4e5adde
Compare
alkesh
commented
Aug 13, 2026
| @@ -22,14 +22,7 @@ def scholarship_funding_eligibility_status(application) | |||
| end | |||
|
|
|||
| def scholarship_eligibility_in_review?(application) | |||
Contributor
Author
There was a problem hiding this comment.
I'm not sure why this method had so much logic, when it could just check the funding_eligiblity_status_code which is set by the FundingEligibility calculator.
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 14, 2026 16:13
c6e21d4 to
fd226c8
Compare
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 17, 2026 13:20
fd226c8 to
3bf35d8
Compare
alkesh
force-pushed
the
NPQ-3873-previous-funding-after-login
branch
from
August 17, 2026 13:34
cc7fc0d to
682ac2e
Compare
Base automatically changed from
NPQ-3873-previous-funding-after-login
to
NPQ-3741-post-MVP-feature-branch
August 18, 2026 08:40
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 18, 2026 09:08
3bf35d8 to
138e7a2
Compare
alkesh
marked this pull request as ready for review
August 18, 2026 09:18
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 18, 2026 10:12
138e7a2 to
496e2ed
Compare
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 18, 2026 12:55
496e2ed to
242d1e8
Compare
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 18, 2026 13:06
242d1e8 to
7293f57
Compare
alkesh
force-pushed
the
NPQ-3930-ehco-journey
branch
from
August 18, 2026 13:17
7293f57 to
e3ff2a8
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Ticket: NPQ-3930
Applying for Early headship coaching offer
Changes proposed in this pull request
ehco_headteacher,ehco_previously_fundedandehco_funding_not_availablestepsineligible_for_fundingstep instead ofehco_funding_not_availableehco_possible_fundingpageeligible_with_urn_and_addressthat can be used by the feature specs