Skip to content

Fix TrackManager startup command ordering - #220

Open
BanjoR wants to merge 1 commit into
DCC-EX:mainfrom
BanjoR:codex/EX-Installer-ex-installer-track-order
Open

BanjoR wants to merge 1 commit into
DCC-EX:mainfrom
BanjoR:codex/EX-Installer-ex-installer-track-order

Conversation

@BanjoR

@BanjoR BanjoR commented Aug 16, 2026 •

Copy link
Copy Markdown

Automatic issue closing Fixes #207 ## Issue and scope - Authoritative issue: EX-Installer #207. - Scope: change EXCommandStation.generate_myAutomation() so generated startup output emits AUTOSTART, TrackManager SET_TRACK/DC SETLOCO commands, POWERON, then DONE; preserve existing roster output and unrelated configuration behavior. - Files changed: ex_installer/ex_commandstation.py and tests/test_ex_commandstation.py. - Personal integration code and unrelated protocol behavior are explicitly out of scope. - Superseded PRs: none identified; repository search found this as the only PR for issue #207. ## Validation - Full available pytest suite: python -m pytest -q -p no:cacheprovider — 4 passed. - Full available unittest suite: python -m unittest discover -s tests -v — 4 passed. - Focused regression suite: python -m pytest -q -p no:cacheprovider tests/test_ex_commandstation.py — 4 passed. - Compile/static checks: python -m compileall -q ex_installer tests — passed; in-memory compilation of both changed files — passed. - Diff hygiene: git diff --check — passed; final checkout clean with exactly the two changed paths above. - Pre-existing warning: in-memory compilation reports the existing ex_commandstation.py:727 invalid escape-sequence warning; this change does not touch that line. ## Unavailable checks - Repository-root python -m unittest discover -v is not a usable suite entry point: it discovered 0 tests and returned exit 5 because tests are under tests/; explicit discovery above passed. - PASS - bundled Python 3.12.13 compileall -q -f ex_installer tests with PYTHONPYCACHEPREFIX redirected to a writable temporary cache completed successfully; the checkout remained clean. - flake8, Black, isort, and Ruff are not installed, and no repository formatter workflow is configured. - GitHub Actions: the repository exposes Docs and project-automation workflows, not a Python test/CI workflow. Docs run #35 is action_required with no jobs; no required test check is available. - Hardware validation: Not run—no hardware available; it is not required for this source-level output-ordering change. If maintainers want a bench check, configure both tracks A and B as MAIN with auto power-on, generate myAutomation.h, and verify the command order is AUTOSTART, both SET_TRACK lines, POWERON, DONE. This pull request is ready for maintainer review.

Current exact-head CI status

N/A — No BanjoR fork Actions run exists for exact head 868ea3ce3358ab0f2c5f1e309975ea130b8ef958; no hosted code-test result is claimed. Local validation above is the available evidence.

@github-actions github-actions Bot added the EX-Installer Item relates to EX-Installer label Aug 16, 2026
@BanjoR
BanjoR marked this pull request as ready for review August 17, 2026 09:29

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

EX-Installer Item relates to EX-Installer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug Report: Configuring TrackManager with auto power on only turns on track A power

1 participant