Conversation
BanjoR
marked this pull request as ready for review
August 17, 2026 09:29
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic issue closing Fixes #207 ## Issue and scope - Authoritative issue: EX-Installer #207. - Scope: change
EXCommandStation.generate_myAutomation()so generated startup output emitsAUTOSTART, TrackManagerSET_TRACK/DCSETLOCOcommands,POWERON, thenDONE; preserve existing roster output and unrelated configuration behavior. - Files changed:ex_installer/ex_commandstation.pyandtests/test_ex_commandstation.py. - Personal integration code and unrelated protocol behavior are explicitly out of scope. - Superseded PRs: none identified; repository search found this as the only PR for issue #207. ## Validation - Full available pytest suite:python -m pytest -q -p no:cacheprovider— 4 passed. - Full available unittest suite:python -m unittest discover -s tests -v— 4 passed. - Focused regression suite:python -m pytest -q -p no:cacheprovider tests/test_ex_commandstation.py— 4 passed. - Compile/static checks:python -m compileall -q ex_installer tests— passed; in-memory compilation of both changed files — passed. - Diff hygiene:git diff --check— passed; final checkout clean with exactly the two changed paths above. - Pre-existing warning: in-memory compilation reports the existingex_commandstation.py:727invalid escape-sequence warning; this change does not touch that line. ## Unavailable checks - Repository-rootpython -m unittest discover -vis not a usable suite entry point: it discovered 0 tests and returned exit 5 because tests are undertests/; explicit discovery above passed. - PASS - bundled Python 3.12.13compileall -q -f ex_installer testswithPYTHONPYCACHEPREFIXredirected to a writable temporary cache completed successfully; the checkout remained clean. -flake8, Black, isort, and Ruff are not installed, and no repository formatter workflow is configured. - GitHub Actions: the repository exposes Docs and project-automation workflows, not a Python test/CI workflow. Docs run #35 isaction_requiredwith no jobs; no required test check is available. - Hardware validation: Not run—no hardware available; it is not required for this source-level output-ordering change. If maintainers want a bench check, configure both tracks A and B as MAIN with auto power-on, generatemyAutomation.h, and verify the command order isAUTOSTART, bothSET_TRACKlines,POWERON,DONE. This pull request is ready for maintainer review.Current exact-head CI status
N/A — No BanjoR fork Actions run exists for exact head
868ea3ce3358ab0f2c5f1e309975ea130b8ef958; no hosted code-test result is claimed. Local validation above is the available evidence.