fix: impersonate Chrome for Bandcamp downloads - #94
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe yt-dlp integration detects Bandcamp URLs and applies Chrome impersonation arguments to audio download and album metadata commands. The README documents the optional ChangesBandcamp yt-dlp support
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
D3SOX
marked this pull request as ready for review
August 4, 2026 20:27
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/ytdlp.ts`:
- Around line 34-35: Ensure the yt-dlp installation used by the project provides
Chrome impersonation support, including the optional curl-cffi backend required
by BANDCAMP_IMPERSONATION_ARGS. Pin a compatible yt-dlp/curl-cffi setup or add a
capability check that detects unavailable support and handles it before Bandcamp
metadata or download commands run.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--impersonate chrometo Bandcamp track downloadsWhy
Bandcamp may return a client-challenge page to yt-dlp instead of track or album metadata. Chrome impersonation works around that response so Bandcamp downloads can proceed.
Validation
bun test src/ytdlp.test.tsbun run lintSummary by CodeRabbit
Bug Fixes
Documentation
curl_cffibackend required for Bandcamp support.