Skip to content

Restore hosted authored-Scene artifact parity - #243

Merged
DecisionNerd merged 1 commit into
mainfrom
feature/authored-scene-artifact-parity
Aug 26, 2026
Merged

Restore hosted authored-Scene artifact parity#243
DecisionNerd merged 1 commit into
mainfrom
feature/authored-scene-artifact-parity

Conversation

@DecisionNerd

@DecisionNerd DecisionNerd commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the bounded three-point reference scatter series to the Node hosted authored-Scene generator
  • preserve the Python generator record, style, and legend order exactly
  • restore byte-identical Python/Node artifacts at all four hosted evidence tiers

Validation

  • exact artifact verifier at 100, 10K, 100K, and 1M points
  • Rust SVG, raster, and browser-painter artifact checks
  • Rust Scene tests (51 passed)
  • focused Python Scene/export tests (264 passed)
  • full Node suite (199 passed)
  • browser render smoke
  • ownership audit, Ruff, formatting, and full pre-commit

Advances #116 by repairing the changed-main hosted evidence path.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need. Autofix is disabled.

Summary by CodeRabbit

  • New Features
    • Added the fixture’s bounded reference circle series as a direct scatter layer in authored scene benchmarks.
    • Preserved the series’ data, metadata, styling, legend entry, and scene structure across benchmark tiers.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: eb005193-48ac-4e97-a5e0-6d63b0cdf82c

📥 Commits

Reviewing files that changed from the base of the PR and between 6f4289b and d0a753b.

📒 Files selected for processing (1)
  • packages/xy-node/scripts/generate_authored_scene_benchmark.mjs

Included review availability: 1 review is currently available. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


📝 Walkthrough

Walkthrough

Changes

Authored scene benchmark

Layer / File(s) Summary
Add authored circle scatter layer
packages/xy-node/scripts/generate_authored_scene_benchmark.mjs
authoredScene adds the bounded reference circle series as a direct scatter layer. The layer preserves its coordinates, metadata, styling, legend row, and scene structure across benchmark tiers.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to d0a75

This localized generator update restores hosted authored-Scene artifact parity, and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely summarizes the main change: restoring parity between hosted authored-Scene artifacts.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/authored-scene-artifact-parity

Warning

Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption.


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@DecisionNerd
DecisionNerd merged commit 95adb9d into main Aug 26, 2026
14 checks passed
@DecisionNerd
DecisionNerd deleted the feature/authored-scene-artifact-parity branch August 26, 2026 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant