fix(exec): bound reopen and fixed-hop query memory - #907
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Comment |
This comment has been minimized.
This comment has been minimized.
b9c6284 to
781aec1
Compare
781aec1 to
7f9091b
Compare
Summary
_all, and validate concurrent topology generations before servingLIMITuses bounded TopK, expose query-local expansion/sort/memory/RSS evidence, and persist typed per-phase ladder failuresRoot-cause evidence
The prior S20 run completed ingest at about 688 MB peak RSS, then reached about 3.33 GB during reopen/recount and was kernel-OOM-killed during fixed-hop execution at about 3.80 GB anonymous RSS. The old
node_countmaterialized node and relationship inventories, and an absent/unreadable adjacency index built a graph-cardinality HashMap in anonymous memory.This change removes both graph-cardinality allocation paths. Lazy repair never mutates immutable generation contents; it writes a provider-isolated cache on the admitted project volume (or configured spill volume), is single-flight across concurrent queries, and fails closed on build/generation errors.
Verification
cargo test -p graphforge-exec --lib— 859 passed, 13 ignoredcargo test -p graphforge-api --lib -- --test-threads=1— 657 passedcargo clippy -p graphforge-exec -p graphforge-api --lib -- -D warnings— passedcargo fmt --all -- --check— passedgit diff --check— passedThe exact-head 4 GiB Fly S20 plus lower-rung RSS plateau remains the pre-merge acceptance proof and will be attached to this PR before merge.
Closes #904
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.