GH-954 Enforce godot-cpp Variant to use 8-byte alignment - #1768
Merged
Conversation
Naros
added
cherrypick:2.4
Naros
removed
cherrypick:2.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes GH-954
Upstream
godot-cppfix in the queueVariant's are 8-byte aligned godotengine/godot-cpp#2038Description
In https://github.com/godotengine/godot-cpp/pulls/1958,
godot-cppenforces 8-byte alignment for opaque pointers within the various auto-generated header files from the extension API; however, theVariantclass is defined separately in the repository and omits the alignment.This PR introduces a shim over
Variant.hppsupplied bygodot-cppand guarantees that its internal opaque data pointer resides at an 8-byte offset, which allows the extension to run safely on 32/64-bit platforms with strict alignment rules.