Skip to content

security(reports): authorize the apps a report targets, on every path that uses them #7864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ar2rsawseen wants to merge 5 commits into
base: master
Choose a base branch
from
Open

security(reports): authorize the apps a report targets, on every path that uses them #7864

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a5509a
fix(reports): authorize non-core report targets on create and update
ar2rsawseen Jul 29, 2026
9c5bf84
test(reports): cover authorization of non-core report targets
ar2rsawseen Jul 29, 2026
5fb1a6e
test(reports): cover a dashboards report for a shared dashboard
ar2rsawseen Jul 30, 2026
247b2c7
security(reports): authorize the apps a report will actually have
ar2rsawseen Jul 31, 2026
86e5062
security(reports): authorize a report's apps when enabling, sending a…
ar2rsawseen Aug 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
## Version 25.03.xx
Fixes:
- [reports] Non-core reports, such as dashboard reports, now authorize the object they target on create and update
- [events] Fix sum chart tooltip displaying the raw floating-point value instead of a rounded number

## Version 25.03.50
Expand Down
203 changes: 131 additions & 72 deletions plugins/reports/api/api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,38 +265,55 @@ const FEATURE_NAME = 'reports';
//report for arbitrary apps.
props.report_type = props.report_type || "core";

/**
* Insert the authorized report document
* @returns {void}
*/
function insertReport() {
common.db.collection('reports').insert(props, function(err0, result) {
result = result.ops;
if (err0) {
err0 = err0.err;
common.returnMessage(params, 200, err0);
}
else {
plugins.dispatch("/systemlogs", {params: params, action: "reports_create", data: result[0]});
common.returnMessage(params, 200, "Success");
}
});
}

//apps is authorized whatever the report type. It used to be checked
//only for core reports, so a non-core report could be stored with an
//arbitrary apps list, and a later update flipping report_type to "core"
//would start using that list without it ever having been checked. The
//dashboards drawer hides the app picker, so a legitimate non-core report
//carries an empty apps and is unaffected by this.
if (!appsArePermitted(params, props.apps)) {
return common.returnMessage(params, 401, 'User does not have right to access this information');
}

if (props.report_type === "core") {
if (!props.apps || !Array.isArray(props.apps) || props.apps.length === 0) {
common.returnMessage(params, 400, 'Invalid or missing apps');
return;
}

if (!params.member.global_admin) {
let allowedApps = (getAdminApps(params.member) || [])
.concat(getUserAppsForFeaturePermission(params.member, FEATURE_NAME, 'r') || []);
if (typeof params.member.permission === "undefined" && Array.isArray(params.member.user_of)) {
allowedApps = allowedApps.concat(params.member.user_of);
}
let notPermitted = props.apps.some(function(appId) {
return allowedApps.indexOf(appId) === -1;
});
if (notPermitted) {
insertReport();
}
else {
//a non-core report targets another plugin's object - a
//"dashboards" report renders the dashboard named in
//props.dashboards - and only that plugin knows whether the
//member may use it. Previously nothing checked this, so any
//member with reports-create rights could schedule a report
//against an arbitrary dashboard id.
validateNonCoreUser(params, props, function(authErr, authorized) {
if (!authorized) {
return common.returnMessage(params, 401, 'User does not have right to access this information');
}
}
insertReport();
});
}

common.db.collection('reports').insert(props, function(err0, result) {
result = result.ops;
if (err0) {
err0 = err0.err;
common.returnMessage(params, 200, err0);
}
else {
plugins.dispatch("/systemlogs", {params: params, action: "reports_create", data: result[0]});
common.returnMessage(params, 200, "Success");
}
});
});
break;
case 'update':
Expand Down Expand Up @@ -345,35 +362,54 @@ const FEATURE_NAME = 'reports';
//treated as a non-core type to skip the per-app check.
var effectiveType = props.report_type || report.report_type || "core";

if (effectiveType === "core" && typeof props.apps !== "undefined") {
if (!Array.isArray(props.apps) || props.apps.length === 0) {
return common.returnMessage(params, 400, 'Invalid or missing apps');
}
if (!params.member.global_admin) {
let allowedApps = (getAdminApps(params.member) || [])
.concat(getUserAppsForFeaturePermission(params.member, FEATURE_NAME, 'r') || []);
if (typeof params.member.permission === "undefined" && Array.isArray(params.member.user_of)) {
allowedApps = allowedApps.concat(params.member.user_of);
/**
* Apply the authorized update
* @returns {void}
*/
function applyUpdate() {
common.db.collection('reports').update(recordUpdateOrDeleteQuery(params, id), {$set: props}, function(err_update2) {
if (err_update2) {
err_update2 = err_update2.err;
common.returnMessage(params, 200, err_update2);
}
let notPermitted = props.apps.some(function(appId) {
return allowedApps.indexOf(appId) === -1;
});
if (notPermitted) {
return common.returnMessage(params, 401, 'User does not have right to access this information');
else {
plugins.dispatch("/systemlogs", {params: params, action: "reports_edited", data: {_id: id, before: report, update: props}});
common.returnMessage(params, 200, "Success");
}
}
});
}

common.db.collection('reports').update(recordUpdateOrDeleteQuery(params, id), {$set: props}, function(err_update2) {
if (err_update2) {
err_update2 = err_update2.err;
common.returnMessage(params, 200, err_update2);
}
else {
plugins.dispatch("/systemlogs", {params: params, action: "reports_edited", data: {_id: id, before: report, update: props}});
common.returnMessage(params, 200, "Success");
//Authorize the apps the report will actually have, which is the
//submitted list when one is sent and the stored list otherwise.
//Checking only the submitted list let an update omit apps to keep a
//stored list that was never checked, and flip report_type to "core"
//so that list started being used.
var effectiveApps = (typeof props.apps !== "undefined") ? props.apps : report.apps;
if (!appsArePermitted(params, effectiveApps)) {
return common.returnMessage(params, 401, 'User does not have right to access this information');
}

if (effectiveType === "core") {
if (typeof props.apps !== "undefined" && (!Array.isArray(props.apps) || props.apps.length === 0)) {
return common.returnMessage(params, 400, 'Invalid or missing apps');
}
});
applyUpdate();
}
else {
//authorize the merged report, not just the payload: a
//partial update may leave the target (props.dashboards)
//in the stored document, and repointing an existing
//report at another dashboard must be checked too. A copy
//is passed so the authorize flag never reaches $set.
var mergedReport = Object.assign({}, report, props);
mergedReport.report_type = effectiveType;
validateNonCoreUser(params, mergedReport, function(authErr, authorized) {
if (!authorized) {
return common.returnMessage(params, 401, 'User does not have right to access this information');
}
applyUpdate();
});
}
});
});
break;
Expand Down Expand Up @@ -623,40 +659,63 @@ const FEATURE_NAME = 'reports';
}

/**
* validation function for verifing user have permission to access infomation or not for core type of report
* @param {object} params - request params object
* @param {object} props - report related props
* @param {func} cb - callback function
* @return {func} cb - callback function

function validateCoreUser(params, props, cb) {
var userApps = getUserApps(params.member);
var apps = props.apps;
var isAppUser = apps.every(function(app) {
return userApps && userApps.indexOf(app) > -1;
});

if (!params.member.global_admin && !isAppUser) {
return cb(null, false);
* Whether the member may schedule a report for every app in a list.
*
* An empty or absent list is permitted: a non-core report legitimately has no apps,
* since the dashboards drawer hides the app picker. What must never pass is a list
* naming an app the member cannot read, whatever the report type, because a later
* update can flip report_type to "core" and the stored list would then be used.
*
* Legacy members have no permission object and reach apps through user_of, so they
* are allowed for those, matching how /o/reports/all and the alerts endpoints treat
* them. Without it they could not schedule reports for their own apps.
*
* @param {object} params - request params object, for member and global_admin
* @param {Array} apps - app ids the report targets
* @returns {boolean} true when every app is permitted
*/
function appsArePermitted(params, apps) {
if (params.member.global_admin) {
return true;
}
else {
return cb(null, true);
if (!Array.isArray(apps) || apps.length === 0) {
return true;
}

let allowedApps = (getAdminApps(params.member) || [])
.concat(getUserAppsForFeaturePermission(params.member, FEATURE_NAME, 'r') || []);
if (typeof params.member.permission === "undefined" && Array.isArray(params.member.user_of)) {
allowedApps = allowedApps.concat(params.member.user_of);
}
allowedApps = allowedApps.map(String);
return apps.every(function(appId) {
return allowedApps.indexOf(appId + "") > -1;
});
}
*/

/**
* validation function for verifing user have permission to access infomation or not for not core type of report
* Verify the member may use a non-core report's target.
*
* A non-core report_type names the plugin that owns the report, and that
* plugin authorizes the target through the /report/authorize event: the
* dashboards plugin checks view access to report.dashboards there. This
* fails closed, so a report type whose plugin does not answer the event is
* not authorized. A plugin adding a new report type must implement
* /report/authorize for it.
*
* Core reports are authorized inline against the member's per-app reports
* permission instead, so they never reach this.
*
* @param {object} params - request params object
* @param {object} props - report related props
* @param {func} cb - callback function

* @param {object} props - report related props
* @param {function} cb - callback receiving (err, authorized)
*/
function validateNonCoreUser(params, props, cb) {
plugins.dispatch("/report/authorize", { params: params, report: props }, function() {
var authorized = props.authorized || false;
//the flag is only how the dispatch reports its result back; it must
//not be persisted onto the report document
delete props.authorized;
cb(null, authorized);
});
}
*/
}());
Loading