docs(tools): fix stale proxy connected_account_id docstring [PLEN-2345] - #62
Open
Zen (zen-agent) wants to merge 2 commits into
Open
docs(tools): fix stale proxy connected_account_id docstring [PLEN-2345]#62Zen (zen-agent) wants to merge 2 commits into
Zen (zen-agent) wants to merge 2 commits into
Conversation
The proxy endpoint stopped accepting empty auth context (returns 400 ``ExternalProxy_MissingAuthContext`` when neither ``connected_account_id`` nor ``custom_connection_data`` is provided), so the docstring's claim that an omitted id falls back to "the default account for the project" no longer matches runtime behavior — callers were hitting an undocumented 400 in production. Updates both the sync and async ``proxy()`` methods in ``composio_client/resources/tools.py``. CONTRIBUTING.md notes that manual patches in generated files are persisted across regenerations. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com> Co-authored-by: Karan Vaidya <karan@composio.dev> Co-authored-by: Uday Sidagana <129588963+Uday-sidagana@users.noreply.github.com>
Zen (zen-agent)
force-pushed
the
zen/plen-2345-proxy-docstring-5gi4le
branch
from
April 29, 2026 12:23
20de705 to
fc5ba4d
Compare
Alberto Schiabel (jkomyno)
approved these changes
Apr 29, 2026
Alberto Schiabel (jkomyno)
left a comment
Alberto Schiabel (jkomyno)
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the PLEN-2345 docstring follow-up. No blocking findings. The sync and async proxy docstrings now match the current auth-context requirement. I treated the failing lint/test jobs as pre-existing per the PR notes; the changed file is docstring-only and build is green.
Addresses jkomyno's review on PR #62. The generated client sources were ASCII-only before this change; the previous commit introduced two em dashes (sync + async ``proxy()`` docstrings). Replacing each ``provided —`` with ``provided. `` keeps the file consistent with the rest of the generated tree and avoids surprising downstream tooling that assumes ASCII. Co-authored-by: Karan Vaidya <karan@composio.dev> Co-authored-by: Uday Sidagana <129588963+Uday-sidagana@users.noreply.github.com> Co-authored-by: karan <karan@composio.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PLEN-2345. The proxy endpoint stopped accepting empty auth context — it now returns 400
ExternalProxy_MissingAuthContextwhen neitherconnected_account_idnorcustom_connection_datais provided (hermes#9582, shipped 2026-04-24 as part of the PLEN-2166 security fix).The stale docstring claim — "if not provided, will use the default account for the project" — no longer matches runtime behavior. Callers following the docstring hit an undocumented 400 in production (broke custom Salesforce / Databricks / Google Docs tools).
Updates both the sync (
ToolsResource.proxy) and async (AsyncToolsResource.proxy) variants insrc/composio_client/resources/tools.py.How did I test this PR
CONTRIBUTING.mdconfirms manual patches in generated files are persisted across regenerations.CI status
build— passlint,test— pre-existing failures onmain(commit36e16687), unrelated to this PR:lintflags[no-redef]errors in the generatedsrc/composio_client/types/trigger_instance_list_active_response.py(5 fields).testfails ontests/api_resources/tool_router/test_session.pybecause the fixture sends aworkbench.sandbox_sizeproperty that the OpenAPI mock-server schema rejects (E3009 Unknown property).Both reproduce on
mainso they were not introduced here.🤖 Generated with Claude Code