Repository navigation
Replace the subclasses of CCE pools with map strcuture and class factory - #15239
Merged
Mab879 merged 1 commit intoOct 26, 2026
Conversation
teacup-on-rockingchair
requested review from
Mab879,
ggbecker,
jan-cerny,
marcusburghardt and
vojtapolasek
as code owners
October 23, 2026 06:35
teacup-on-rockingchair
added
usability
Member
|
Seems this needs a rebase. |
…factory When adding new platform with CCEs pool file, instead of adding class definition, rework the implementation to: - Generate CCE pool classes from a static table - Replace the hand-written RedhatCCEFile, SLE12CCEFile, SLE15CCEFile and SLE16CCEFile subclasses with a factory driven by CCE_POOL_FILES Each row maps a --cce-pool name to the generated class name and its available-CCE file in shared/references, so supporting a new product is a one-line change instead of a new class. The generated classes keep their previous names and are still exported from ssg.cce, so existing imports and CCE_POOLS lookups should be unchanged. - Add the slmicro6 pool backed by cce-slmicro6-avail.txt, which makes `utils/fix_rules.py add-cce --cce-pool slmicro6` usable.
teacup-on-rockingchair
force-pushed
the
cce_fix_rules_use_simplify_new_platform
branch
from
October 24, 2026 08:26
027aae4 to
a797266
Compare
Contributor
Author
|
/retest |
Mab879
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
When adding new platform with CCEs pool file, instead of adding class definition, rework the implementation to:
Generate CCE pool classes from a static table
Replace the hand-written RedhatCCEFile, SLE12CCEFile, SLE15CCEFile and SLE16CCEFile subclasses with a factory driven by CCE_POOL_FILES
Each row maps a --cce-pool name to the generated class name and its available-CCE file in shared/references, so supporting a new product is a one-line change instead of a new class.
Add the slmicro6 pool backed by cce-slmicro6-avail.txt, which makes
utils/fix_rules.py add-cce --cce-pool slmicro6usable.Review Hints: