Repository navigation
Conversation
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
ggbecker
force-pushed
the
build-collections-extra-patches
branch
from
September 29, 2026 08:40
cd59e95 to
29d3df4
Compare
Member
Author
|
Ansible.posix is a supported module so we can use it as dependency. The roles and collection have been updated accordingly. |
ggbecker
force-pushed
the
build-collections-extra-patches
branch
from
September 29, 2026 10:10
29d3df4 to
3ca3ad6
Compare
jan-cerny
reviewed
Sep 29, 2026
jan-cerny
reviewed
Sep 29, 2026
ggbecker
force-pushed
the
build-collections-extra-patches
branch
from
September 29, 2026 12:29
3ca3ad6 to
c3b940a
Compare
The HIPAA profile description contained a curly apostrophe (U+2019) in "individuals'". This trips the ansible-test no-smart-quotes sanity test when the profile description is rendered into the generated Ansible collection role READMEs, blocking Automation Hub certification. Replace it with an ASCII apostrophe in every affected product profile: almalinux9, ol7, ol8, ol9, rhel8, rhel9, sle15.
Add utils/check_smart_quotes.py, which detects (and with --fix, replaces) Unicode smart quotes with their ASCII equivalents, mirroring the ansible-test no-smart-quotes sanity test that gates Automation Hub certification of the generated Ansible collection. Register it as the test-check-smart-quotes CTest scoped to products/*/profiles (where the collection role READMEs are sourced from), plus a mypy check, following the existing utils/check_eof.py pattern.
ggbecker
force-pushed
the
build-collections-extra-patches
branch
from
October 1, 2026 11:23
c3b940a to
fb65c6e
Compare
The platform version emitted into each generated role's meta/main.yml was derived with platform[-1], so 'rhel10' yielded '0' instead of the release, and non-RHEL EL products fell back to a hardcoded '7' + '8'. Derive the version from the trailing digits of the product id instead (rhel10 -> '10', rhel8 -> '8', ol9 -> '9'). Also quote min_ansible_version and the platform version in the meta template so they satisfy the Galaxy schema's string types. The RHEL 10 value '10' is accurate but is not accepted by ansible-lint's schema[meta] when the linter is pinned to the ansible-core 2.16 certification floor (24.12.2), whose EL version enum caps at '9'. Accurate platform metadata is preferred; the collection excludes only the RHEL 10 meta files from schema validation (schema[meta] cannot be waived via skip_list). The metadata template is filled by @Placeholder@ string substitution (including structural tokens like @GALAXY_TAGS@) so it is not valid standalone YAML; add it to .yamllint's ignore list so the changed-file yamllint CI check skips it.
The verification step flagged ansible.posix references as unrewritten FQCNs, but ansible.posix is now a declared collection dependency and is intentionally retained. Narrow the grep to the vendored collection (community.general), which is the only FQCN that must be rewritten.
ggbecker
force-pushed
the
build-collections-extra-patches
branch
from
October 2, 2026 12:46
fb65c6e to
5ea2690
Compare
ggbecker
marked this pull request as ready for review
October 2, 2026 12:46
ggbecker
requested review from
a team,
Mab879,
marcusburghardt,
matusmarhefka and
vojtapolasek
as code owners
October 2, 2026 12:46
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
jan-cerny
reviewed
Oct 5, 2026
| --output-dir /tmp/collection \\ | ||
| [--version 0.1.82] # defaults to the SSG project version from CMakeLists.txt \\ | ||
| [--namespace redhatofficial] \\ | ||
| [--target galaxy|hub] \\ |
Member
There was a problem hiding this comment.
Suggested change
| [--target galaxy|hub] \\ | |
| [--target galaxy|hub] \\ |
| documentation, issue tracker, author, and installation server automatically: | ||
|
|
||
| ```bash | ||
| python3 utils/ansible_roles_to_collection.py \ |
Member
There was a problem hiding this comment.
Does --galaxy-server need to be included in this command here or not?
Member
Author
There was a problem hiding this comment.
In this case we are only building the collection to manually upload it later. At this moment we are not automatically pushing any collections to galaxy hub. We do it manually by uploading the final tar.gz file generated by this command.
|
|
||
| ## Support | ||
|
|
||
| This collection is maintained by Red Hat RHEL Security Content. |
Member
There was a problem hiding this comment.
Who/what is "Red Hat RHEL Security Content"?
Member
Author
There was a problem hiding this comment.
I'd simply remove this line to not create more confusion.
Align the --target line in the usage docstring with the surrounding options, and remove the inaccurate maintainer sentence from the generated collection README Support section. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Member
|
/packit build |
jan-cerny
approved these changes
Oct 8, 2026
jan-cerny
left a comment
jan-cerny
left a comment
Member
There was a problem hiding this comment.
I have verified that the tarball and collections can be generated using the steps in docs/release_process.md.
Member
|
@ComplianceAsCode/suse-maintainers @ComplianceAsCode/oracle-maintainers Please take a look and review this PR, namely the changes in your profile files. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Rationale:
Review Hints:
pytest tests/unit/utils/test_ansible_roles_to_collection.py.utils/ansible_roles_to_collection.pytogether with the release process documentation changes.