Skip to content

Fix import assertions to import attributes syntax - #1989

Merged
shiffman merged 1 commit into
CodingTrain:mainfrom
fturmel:PR/import-attribute-fix
Aug 4, 2026
Merged

Fix import assertions to import attributes syntax#1989
shiffman merged 1 commit into
CodingTrain:mainfrom
fturmel:PR/import-attribute-fix

Conversation

@fturmel

@fturmel fturmel commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator

Hey @shiffman, hope all is well.

I noticed an error in the Netlify pipeline when you merged your PR yesterday. This should fix the problem.

Import assertions were superseded by import attributes after we shipped this YouTube redirect feature on the site. Node 22+ doesn't support this assert syntax anymore. I think we're seeing this issue appear now because Node 20 is EOL, and Netlify packages edge functions to run on Deno Deploy where the actual runtime is Deno AFAIK.

CleanShot 2026-08-04 at 14 51 20@2x

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import/with
https://v8.dev/features/import-attributes

@netlify

netlify Bot commented Aug 4, 2026

Copy link
Copy Markdown

Deploy Preview for codingtrain ready!

Name Link
🔨 Latest commit 6eb2d86
🔍 Latest deploy log https://app.netlify.com/projects/codingtrain/deploys/6a723aa50f406b0008a6caa4
😎 Deploy Preview https://deploy-preview-1989--codingtrain.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@fturmel
fturmel force-pushed the PR/import-attribute-fix branch from 569b7a7 to 6eb2d86 Compare August 4, 2026 19:16
@fturmel

fturmel commented Aug 4, 2026

Copy link
Copy Markdown
Collaborator Author

Looks fixed in the preview build.

CleanShot 2026-08-04 at 15 20 00@2x

@shiffman

shiffman commented Aug 4, 2026

Copy link
Copy Markdown
Member

Thanks for catching this!!

@shiffman
shiffman merged commit 584a414 into CodingTrain:main Aug 4, 2026
6 checks passed
@fturmel
fturmel deleted the PR/import-attribute-fix branch August 4, 2026 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants