Repository navigation
[BE-133] PaymentsController applies RolesGuard class-wide with no route-level distinction for read vs. admin-only actions #1327
Description
Overview
backend/src/payments/payments.controller.ts applies @UseGuards(RolesGuard) at the class level (see [BE-92] for why this is currently non-functional). Once that's fixed, it's worth confirming the role requirements are actually differentiated per-route — a shipper should be able to view their own payment status, while triggering a manual release/refund should be admin-only. A single class-level role list can't express that distinction.
Tasks
- Move
@Roles(...)to individual route handlers as needed so read access and admin-mutation access have independently correct role requirements. - Add tests for each.
Acceptance Criteria
- A shipper can view their own payment status but cannot trigger an admin-only payment action, proven by a test.
Dependencies
[BE-92].
Notes for Contributors
Comment below to be assigned.
Activity
maybay-dev commentedon Aug 27, 2026
@maybay-dev has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @maybay-dev to this issue.
shakourllahfashola-dev commentedon Aug 27, 2026
@shakourllahfashola-dev has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @shakourllahfashola-dev to this issue.
temitope-007 commentedon Aug 27, 2026
@temitope-007 has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @temitope-007 to this issue.
Juwiix commentedon Aug 27, 2026
@Juwiix has applied to work on this issue as part of the Stellar Wave Program's 8th wave.
ℹ️ Repo Maintainers: To accept this application, review their application or assign @Juwiix to this issue.
drips-wave commentedon Aug 27, 2026
Congratulations, @Juwiix! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on August 31, 2026.
🧑💻 @Juwiix: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.
Warning
When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.
🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.
🌊 Happy Wave 🌊
grantfox-oss commentedon Aug 28, 2026
🎉 This issue has been marked as completed on GrantFox as part of the Third Campaign campaign!
@Juwiix's PR #1428 was approved and merged by @mftee.
🏆 @Juwiix: You earned 35 FoxPoints for this contribution! Your current tier: Explorer (296 total points). Track your full progress on GrantFox.
👏 Great work, @Juwiix! Keep contributing to CodeGirlsInc.
drips-wave commentedon Aug 28, 2026
This issue has been completed by @Juwiix as part of the Stellar Wave Program's 8th Wave 🥳
😎 @Juwiix: You earned 200 Points for completing this issue! After the current Wave ends, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.
🧑💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.