feat: add VirtioNetworkDeviceConfiguration.GetMACAddress() getter#221
Open
mvanhorn wants to merge 1 commit into
Open
feat: add VirtioNetworkDeviceConfiguration.GetMACAddress() getter#221mvanhorn wants to merge 1 commit into
mvanhorn wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) this PR fixes:
Fixes #136
Additional documentation
Adds a
GetMACAddress() *MACAddressgetter toVirtioNetworkDeviceConfiguration, mirroring the existingSetMACAddresssetter. A newgetNetworkDevicesVZMACAddressObjective-C shim reads the value back from the underlyingVZMACAddress, so callers can inspect the address they configured (or the system-assigned one). Follows the signature the maintainer specified in the issue thread; covered by an added case innetwork_test.go.