Repository navigation
fix(core): stop sub-agent streams from bubbling to parent - #1003
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Walkthrough子代理执行器新增会话相关类型导入。执行器统一解析请求 ID。前台运行根据会话上下文解析回调。后台运行继续不传递回调。 Changes子代理回调流程
Estimated code review effort: 2 (简单) | ~10 分钟 Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/core/src/llm-core/agent/sub-agent/executor.ts`:
- Around line 108-120: 在执行流程中提前计算一次最终 requestId,优先使用
options.runConfig?.configurable?.agentContext?.requestId,否则回退到 runId;将该值同时传给
resolveCallbacks 和 options.target.agent.generate,确保回调解析与生成调用使用同一请求标识。
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 45ab637e-a0e9-4a1b-a470-644679d224e3
📒 Files selected for processing (1)
packages/core/src/llm-core/agent/sub-agent/executor.ts
This pr prevents sub-agent intermediate tokens and tool calls from being streamed as if they were the main agent's output.
New Features
Bug Fixes
Other Changes
Validation