fix: do not compare proposer index in proposer boost#9653
Conversation
There was a problem hiding this comment.
Code Review
This pull request removes the expectedProposerIndex parameter from the forkChoice.onBlock method, simplifying the proposer boost logic by removing the check that matched the block's proposer index with the expected proposer index. Consequently, the unused getBeaconProposerOrNull helper method and its caching mechanism have been removed from the state view classes and interfaces, and associated tests have been updated. I have no feedback to provide as there are no review comments.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Performance Report🚀🚀 Significant benchmark improvement detected
Full benchmark results
|
Previously in #9565 we added dependent root check, but didn't remove the proposer index check.