Repository navigation
Link editor - #368
Draft
jgonggrijp wants to merge 10 commits into
Draft
Link editor#368jgonggrijp wants to merge 10 commits into
jgonggrijp wants to merge 10 commits into
Conversation
Need editing motivation to hit the right branch
OA.editing has to be the @id of an object in JSON-LD
…d API (#301) Inserted body values are optional
…d API (#301) Body is replaced wholesale, so client must always send a complete body. Also, number of triples grows by 1 because of the as:updated date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since I'll be away for two weeks, this draft PR serves to document what I've been working on. My plan is to address #301 by combining a (small) datamodel change and a UI change.
In the datamodel, I want to allow the
oa:hasBodyof an edit annotation to be a nested resource that can have roughly the same properties as anedpoprec:Fieldoredpoprec:DigitizationField, except for usingrdf:valueinstead ofedpoprec:originalTextandedpoprec:summaryText. The use ofrdf:valuefor the "main" content of the edit follows the convention ofoa:TextualBody(though without requiring that the resource actually hasoa:TextualBodyas itsrdf:type). This also avoids the confusion that might arise from an edit containing an override value in a property namededpoprec:originalText. Existing edits with just a string as body will continue to work and will be considered equivalent to therdf:valueof a nested body.In the UI, I want to turn the field editor into an input group with a dropdown button on the left. The dropdown lets you pick which subproperty of the annotation body you're editing. All fields have a "text" and a "link" option, with the "text" option being selected by default and letting you set the
rdf:value. This is equivalent to the existing functionality. Picking the "link" option, however, makes it possible to set theedpoprec:authorityRecordand thus create a link. For the digitization field, I want to also add "IIIF", "image" and "thumbnail" options, which let the user set theedpoprec:iiifManifest,edpoprec:urlandedpoprec:previewURL, respectively.Executing this plan involves the following layers:
POSTandPUThandlers for/api/annotations/AnnotationmodelpresentableContentsAnnotationEditView