fix(gh-workflows): exempt upstream-sync PR titles from Conventional Commits gate - #130
Merged
Merged
Conversation
…ommits gate The sync PR title format (Upstream Sync: LiteLLM vX.Y.Z) never matches Conventional Commits, so every sync PR fails the "Validate PR title" check unless the ignore-semantic-pull-request label is added manually after creation, as happened for PR #121. Add the label at PR-creation time so future sync PRs pass the gate automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
@greptileaiand received a Confidence Score of at least 4/5 before requesting a maintainer reviewDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
PR #128 ("Upstream Sync: LiteLLM v1.95.0") failed the "Validate PR title" check because its auto-generated title has no Conventional Commits prefix. Its predecessor, PR #121, only passed because the
ignore-semantic-pull-requestlabel was added to it by hand twelve hours after creation:carto-upstream-sync-main.ymlnever applied that label itself, so every future sync PR would repeat this failure without manual intervention. This PR adds the label toLABEL_ARGSat PR-creation time.Not a testable code path (bash inside a GitHub Actions step); validated by reading
conventional-commits.yml'signoreLabelsconfig and PR #121's label history above, and by parsing the edited YAML withpython3 -c "import yaml; yaml.safe_load(...)". Appliedignore-semantic-pull-requestto PR #128 by hand as an immediate unblock; this PR prevents the recurrence.Type
🚄 Infrastructure
Changes
carto-upstream-sync-main.yml: always add theignore-semantic-pull-requestlabel when creating an upstream-sync PR, since its title format never matches Conventional Commits.