Skip to content

fix(gh-workflows): exempt upstream-sync PR titles from Conventional Commits gate - #130

Merged
mateo-di merged 1 commit into
carto/mainfrom
litellm_upstream_sync_pr_title_label
Aug 12, 2026
Merged

fix(gh-workflows): exempt upstream-sync PR titles from Conventional Commits gate#130
mateo-di merged 1 commit into
carto/mainfrom
litellm_upstream_sync_pr_title_label

Conversation

@mateo-di

Copy link
Copy Markdown
Collaborator

Relevant issues

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have requested a Greptile review by commenting @greptileai and received a Confidence Score of at least 4/5 before requesting a maintainer review

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

Screenshots / Proof of Fix

PR #128 ("Upstream Sync: LiteLLM v1.95.0") failed the "Validate PR title" check because its auto-generated title has no Conventional Commits prefix. Its predecessor, PR #121, only passed because the ignore-semantic-pull-request label was added to it by hand twelve hours after creation:

$ gh api repos/CartoDB/litellm/issues/121/timeline --paginate -q '.[] | select(.event=="labeled") | "\(.created_at) \(.actor.login) added \(.label.name)"'
2026-07-13T14:21:56Z Cartofante added upstream-sync
2026-07-13T14:21:57Z Cartofante added automated
2026-07-14T02:34:07Z mateo-di added ignore-semantic-pull-request

carto-upstream-sync-main.yml never applied that label itself, so every future sync PR would repeat this failure without manual intervention. This PR adds the label to LABEL_ARGS at PR-creation time.

Not a testable code path (bash inside a GitHub Actions step); validated by reading conventional-commits.yml's ignoreLabels config and PR #121's label history above, and by parsing the edited YAML with python3 -c "import yaml; yaml.safe_load(...)". Applied ignore-semantic-pull-request to PR #128 by hand as an immediate unblock; this PR prevents the recurrence.

Type

🚄 Infrastructure

Changes

carto-upstream-sync-main.yml: always add the ignore-semantic-pull-request label when creating an upstream-sync PR, since its title format never matches Conventional Commits.

…ommits gate

The sync PR title format (Upstream Sync: LiteLLM vX.Y.Z) never matches
Conventional Commits, so every sync PR fails the "Validate PR title" check
unless the ignore-semantic-pull-request label is added manually after
creation, as happened for PR #121. Add the label at PR-creation time so
future sync PRs pass the gate automatically.
@mateo-di mateo-di self-assigned this Aug 12, 2026
@mateo-di
mateo-di marked this pull request as ready for review August 12, 2026 13:13
@mateo-di
mateo-di merged commit 1491f25 into carto/main Aug 12, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant