Improve footer #4 #22
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,12 +1,37 @@ | ||
| --- | ||
| import { Icon } from 'astro-icon/components'; | ||
| const year = new Date().getFullYear(); | ||
| --- | ||
|
|
||
| <footer class="text-muted bg-canvas sticky bottom-0 z-10 text-sm"> | ||
| <!-- Carleton accent bar --> | ||
| <div class="bg-accent/80 h-0.5 w-full"></div> | ||
| <div | ||
| class="mx-auto flex max-w-5xl flex-col items-center gap-2 px-4 py-4 sm:flex-row sm:justify-between" | ||
| > | ||
| <p> | ||
| © {year}{' '} | ||
| <a | ||
| href="https://ccss.carleton.ca" | ||
| target="_blank" | ||
| rel="noopener" | ||
| class="hover:text-accent underline-offset-2 hover:underline" | ||
|
Contributor
There was a problem hiding this comment. Right now the hover behaviour is inconsistent between this and the Github link (this one underlines, the Github links doesn't). Please make them consistent by removing the underline here so it just turns red on hover (consistent with other links on the site as well) |
||
| > | ||
| Carleton Computer Science Society | ||
| </a> | ||
| </p> | ||
| <a | ||
| href="https://github.com/CarletonComputerScienceSociety/showcase" | ||
| target="_blank" | ||
| rel="noopener" | ||
| class="hover:text-accent inline-flex items-center gap-1" | ||
| > | ||
| GitHub | ||
| <Icon | ||
| name="lucide:external-link" | ||
| class="h-3.5 w-3.5" | ||
| aria-hidden="true" | ||
| /> | ||
| </a> | ||
| </div> | ||
| </footer> | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
mx-auto max-w-5xl px-4classes instead ofsite-containermake the footer content unaligned with the main and header content on desktop. Looking at the preview, I think just havingsite-containerhandle the spacing would look cleaner, so please remove the 3 classes I pointed out at the beginning and replace with justsite-containerTo verify this is actually right, the text on the left and right should be aligned with the header's left and right bits and the width of the main content on desktop width.