Skip to content

fix: Paths edited by Path Cursor can sometimes retain detailed handles - #200

Open
StickmanRed wants to merge 2 commits into
developmentfrom
StickmanRed-pathcursor-deselect-fix
Open

fix: Paths edited by Path Cursor can sometimes retain detailed handles#200
StickmanRed wants to merge 2 commits into
developmentfrom
StickmanRed-pathcursor-deselect-fix

Conversation

@StickmanRed

Copy link
Copy Markdown
Collaborator

Description

If you use the Path Cursor's detailed editing on a path, on occasion, the path handles can somehow get stuck to the path. In this PR, each path checks if the project (if it exists) is using the Path Cursor tool, and if it ain't, the path quietly discards the selection handles and moves on.

Testing

  1. Create some paths.
  2. Activate the Path Cursor.
  3. Double-click on a path to enter detailed editing mode.
  4. Move a vertex.
  5. Switch to another tool. The detailed editing handles should be removed.
  6. Undo once. The handles should still be removed. In previous versions the handles still appear.

@StickmanRed StickmanRed added the bug Something isn't working label Aug 22, 2026
@Alani25

Alani25 commented Sep 5, 2026

Copy link
Copy Markdown
Member

Looks good— only came by one issue while testing—
If you use ctrl + z while using the path cursor tool (double click to enter path cursor edit mode of shape, move little, then undo), then re-double clicking with the path cursor to get back into the path cursor edit mode doesn't seem to work.

Tested this on the older editor version and can confirm the same bug is there as well.
If we can cover it in this same PR would be great.

And one more quick thing that might be worth adding— when using the ctrl + a shortcut to select all objects in the frame (while using the path cursor, text tool, or any other tool asides the cursor tool) we should allow it to automatically switch to the cursor tool, otherwise everything gets selected and you can't move it around because you're still on the current tool.

@Alani25
Alani25 self-requested a review September 5, 2026 21:00
@InternetAstronaut

Copy link
Copy Markdown
Contributor

This is because the detailed path editing mode is ported from Legacy Wick. I believe that we should re-do the Path Cursor.

@StickmanRed

Copy link
Copy Markdown
Collaborator Author

I got confused finding a fix for the first problem, because Wick creates new path objects every render... kinda wish we had more control over the paper.js objects

@InternetAstronaut

Copy link
Copy Markdown
Contributor

kinda wish we had more control over the paper.js objects

That's the problem with extremely abstract libraries. You can't control everything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants