Add clips to asset library - #172
Conversation
|
I tried adding an icon but it was SO HARD, so I didn't do it. I'll try getting the rest done soon, thanks for the feedback! Also, a question: would condensing the three toasts to one mean removing the 'importing files' toast? Since that touches the importing code and also it's basically unnecessary, because if there's an importing issue it'll throw an error anyway, so the in progress toast does nothing except tell people sometimes that the import process is really slow. |
…eted false on editing clip
…he6th/Candlestick into add-to-assets-as-wickobj
|
Clips are now numbered on adding to asset library, and clips can't be added to the asset library if they have an asset source. The 'importing files' and 'no identifier' toasts have been removed. Still working on making the 'add to library' button show up after editing the clip. |
|
Update: now, if you change the project's focus by using the breadcrumbs button, the old focus is marked as something you |
|
Another update: if an imported asset has the same name as an existing one, it renames it with -copy. For some reason, you have to do the import twice if there's a duplicate, but I think it's fine for now. |
For quick imports like adding a clip to the asset library, it's highly unnecessary since that takes a second and doesn't require any loading. For importing larger assets into the asset library, it's more necessary to let the user know it's being worked on, as it would take a minute. I'd advise adding an extra parameter to the function that's set to false by default for disabling or enabling that extra toast notification, and for importing assets you can disable it.
If you're still stuck there I can help 👍 Matter of fact, I see you've gotten decent progress done that I've yet to test— if you're okay with me collabing with your code, feel free to list all issues you're coming by and (when you're ready) give me permission to look at it and start doing changes I was also considering turning this into more of an adobe-like "symbol" feature… in which case we'd need to track the original clip based off UUID and toss that into the asset library instead, while also having it update everywhere the asset is used— but for now that's just a thought (as there has been requests for a feature as such). (extra note— I apologize for the late response it seems we're in opposite timezones) |
|
Symbols are probably something for another PR imo. Also, I forgot to say that there's only one toast now since I swapped the createAssets() out for importFileAsAsset(). And yeah, I'm fine with collabing and if you could add an icon it would be really helpful, thanks! I'm quite confused about how to detect in every scenario if a clip has been edited, which is why it's a bit messy with the breadcrumbs button, but the only places it can really slow you down is when you have to edit a clip RIGHT after you make it an asset. But for the core importing, I think we're ok. |



Added a feature to add a clip to the asset library. Tested with buttons as well (but I don't know the first thing about testing so.. yeah) I've also fixed a little typo in the param for the wickobj export function, because the current param says it exports a Wick.Project :P