Skip to content

fixed problem where objects could be added with incorrect identifiers #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
InternetAstronaut wants to merge 2 commits into
base: development
Choose a base branch
from
Open

fixed problem where objects could be added with incorrect identifiers #144

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c76c263
fixed problem where objects could be added with incorrect identifiers
InternetAstronaut Jun 21, 2026
5c6d9e5
Created _'quick'_ version of `_getUniqueIdentifier` which doesn't rec…
InternetAstronaut Jun 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions engine/src/base/Base.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -518,6 +518,9 @@ Wick.Base = class {
this._children = [];
}

// Fix for #142
child.identifier = this._getUniqueIdentifier(child.identifier);

child._parent = this;
child._setProject(this.project);

Expand All @@ -541,6 +544,8 @@ Wick.Base = class {
insertChild(child, index) {
var classname = child.classname;

child.identifier = this._getUniqueIdentifier(child.identifier); // fix for the 3 people who have used this.

if (child._parent === this) {
let result = 0;
let old_index = this._children.indexOf(child);
Expand Down Expand Up @@ -590,6 +595,7 @@ Wick.Base = class {
*/
getLinkedAssets () {
// Implemented by Wick.Frame and Wick.Clip
console.warn(`getLinkedAssets() is implemented by Wick.Frame and Wick.Clip, but this is object is a Wick.${this.classname}.`)
return [];
}

Expand Down