Skip to content

fix: retry failed workspace search with the same keyword - #463

Merged
Qiyuanqiii merged 1 commit into
Qiyuanqiii/docs-current-statefrom
Qiyuanqiii/workspace-search-retry
Oct 23, 2026
Merged

Qiyuanqiii merged 1 commit into
Qiyuanqiii/docs-current-statefrom
Qiyuanqiii/workspace-search-retry

Conversation

@Qiyuanqiii

Copy link
Copy Markdown
Member

Summary

After a workspace search request failed, clicking Search again or pressing Enter with the same keyword left the error visible because the query state did not change. An errored query now refetches when resubmitted unchanged. Successful searches, keyword validation, and the API contract retain their existing behavior.

Stacked on #448 (Qiyuanqiii/workspace-markdown-preview).

Validation

  • The button and Enter regression cases both failed on b6e89e8c481bb38293d584a9204b36916528c834 and pass with the fix.
  • Explorer and Markdown preview suites: 21 tests passed.
  • TypeScript build and Vite production build passed; Vite retains the existing large-chunk warning.
  • OCR completed the changed production component with zero findings. Its default rules exclude test files.
  • Real Chrome, production renderer, and production API: temporarily abort workspace-search requests, remove the interruption, confirm the API returns 200, and resubmit the unchanged keyword. Before: no new request and the error remains. After: a new request returns 200 and the result appears.
  • Go tests, vet, and CLI smoke tests: not run for this frontend-only change.

The PNGs below are committed, unmodified browser captures. Setup and reproduction notes are in the acceptance README.

Before, after the connection recovers and Search is clicked again:

Before: unchanged search remains stuck on the error

After the same action:

After: unchanged search retries and displays the result

Surface governance

  • No Surface is added, promoted, downgraded, deprecated, or removed.
  • Registry item(s): N/A — no Surface change.
  • Target tier / transition: N/A — no Surface change.
  • Entry criteria / decision: N/A — no Surface change.
  • Owner: N/A — no Surface change.
  • Shared Go Application contract: Unchanged workspace search contract.
  • Authority impact: Existing read-only search only.
  • Supported platforms: Existing browser and desktop frontends.
  • Release / test evidence: Focused tests and browser captures above.
  • Compatibility strategy: Existing request shape and query keys.
  • Deprecation window: N/A — no Surface change.
  • Removal / rollback plan: Revert this commit.

Audit

  • No credentials or local runtime data are included.
  • Policy, workspace, sandbox, and persistence boundaries were reviewed.
  • Acceptance README records the changed behavior and verification.

@Qiyuanqiii
Qiyuanqiii added this pull request to stack #483 October 23, 2026 17:13
@Qiyuanqiii
Qiyuanqiii force-pushed the Qiyuanqiii/workspace-search-retry branch from a61ed89 to 7883f63 Compare October 23, 2026 17:16
Base automatically changed from Qiyuanqiii/workspace-markdown-preview to Qiyuanqiii/docs-current-state October 23, 2026 17:17
@Qiyuanqiii
Qiyuanqiii force-pushed the Qiyuanqiii/workspace-search-retry branch from 7883f63 to 76bd5de Compare October 23, 2026 17:17
@Qiyuanqiii
Qiyuanqiii merged commit 7e791c7 into Qiyuanqiii/docs-current-state Oct 23, 2026
@Qiyuanqiii
Qiyuanqiii deleted the Qiyuanqiii/workspace-search-retry branch October 23, 2026 17:17
Qiyuanqiii added a commit that referenced this pull request Oct 23, 2026
…cs-current-state

chore(integration): 将 docs-current-state 批次补齐到 main(#442 #448 #463)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant