Repository navigation
feat(extensions): complete MCP, Plugin and LSP onboarding - #284
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Settings can now complete first-time MCP, Plugin and LSP setup through the shared Go control plane. Users can select a Workspace before a Run exists, register a manual MCP descriptor, upload a pinned Plugin ZIP, or stage an installed language server. Forms retain input after failure, show source/scope/review metadata and provide the next available action. Web/Desktop use the same backend-advertised onboarding capabilities and generated API contract.
Registration stays inert. MCP retains separate discovery and capability reviews; actual calls use the ordinary task/Approval/Gateway path and settings reads their durable audit result. Plugin import retains the existing 4 MiB
plugin.v1validator and explicit package/capability reviews. LSP review persists the existing operator configuration format; a separate bounded symbol-query test returns real server/query/document provenance. A stable manager connects new configurations to model tools, rejects stale queries and owns process cleanup. OS advisory locking and digest checks prevent concurrent configuration overwrites. Explicit CLI/environment LSP files remain authoritative and read-only in settings.Plugin upload preflight uses bounded decoding and canonical re-encoding so supported 3.5–4 MiB payloads do not overflow the browser regex stack. Both encoded-length and decoded-byte limits remain enforced, and malformed or noncanonical input is rejected before the request.
The application preview copy now describes the available service/log view separately from browser availability.
The existing real Edge CI job uses lowercase
nulfor its empty Git configuration, accommodating the Git for Windows 2.56/UCRT regression (upstream #6449). Source-binding failures now retain Git stderr without mixing it into the source metadata.Closes #276.
Validation
0955d7fc0aab7539cdb0fbb0b8930582ae9c7c92, synchronized with main7aac2773451daff1e372647a5733c937c00d2cc7. GitHub reports the PR as mergeable.npm run check:apipass.7aac2773451daff1e372647a5733c937c00d2cc7.go vetfor HTTP, application and Store packages, andgit diff --check, pass.395d7bfc. This is a browser-side preflight probe, not a complete import/install test of a large ZIP. The supported 3.5 MiB, 4 MiB minus one byte and exactly 4 MiB client requests are covered again by the current full frontend suite.Surface governance
Audit