Repository navigation
refactor: register gateway executor checks and reuse payload normalization - #255
Merged
Merged
Conversation
…ation Keep executor availability with each tool registration and run it before charging the tool budget. Reuse registered payload normalizers while retaining each tool family's identity and authorization requirements. Co-authored-by: Codex <codex@openai.com> Co-authored-by: MiniMax-AI-Dev <192945411+MiniMax-AI-Dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gateway executor requirements were maintained in a separate tool-name list, and argument validation repeated the payload-normalizer dispatch already held by the registry. Register the existing executor checks beside the tool definitions and reuse the registered normalizers.
Checks still run before budget charging. Browser calls select the existing Agent Browser or legacy executor from the payload version. Tool-specific identity, lease, operation-key, and live authority checks remain in place; remove the unreachable argument branch for retired host-command proposals.
Cleanup candidates were contributed by MiniMax-AI-Dev; the commit credits both MiniMax-AI-Dev and Codex.
Validation
go test ./internal/toolgateway(local Go 1.26.6), covering catalog membership, dispatch, protocol validation, authorization, and budget ordering.Surface governance
Audit