Repository navigation
refactor: remove placeholders and share provider and HTTP plumbing - #254
Merged
Merged
Conversation
Remove unused mode packages and the forwarding agent ID helper. Share existing HTTP control authorization and provider transport framing without changing provider-specific completion or application authority rules. Co-authored-by: Codex <codex@openai.com> Co-authored-by: MiniMax-AI-Dev <192945411+MiniMax-AI-Dev@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove five unreferenced mode placeholder packages, the forwarding
agent.NewIDhelper, and an accidentally tracked PR draft. Retain the live Task compatibility model and update the Surface inventory references.Execution profile, permission, and interaction controls now reuse the existing authorization helper. OpenAI transports share request-header construction; Responses and Anthropic share their existing SSE framing loop while keeping their distinct completion, tool-call, replay, and error handling.
Cleanup candidates were contributed by MiniMax-AI-Dev; the commit credits both MiniMax-AI-Dev and Codex.
Validation
go test ./internal/llm(local Go 1.26.6).go test ./internal/httpapi -run '^Test(RunExecution(Profile|Permission|Interaction)Control|RunOperationControlsRejectDisabledUnauthorizedAndMalformedRequests)'.Surface governance
ctf-offensive-skeletonsevidence references only; no tier or transition change.Audit