Repository navigation
fix: complete MCP execution through CLI and Thread approvals - #253
Merged
Merged
Conversation
Connect persisted Workspace and Session bindings, use current Gateway read arguments, declare an object root for dynamic MCP schemas, and stop Thread handoffs while waiting for approval. Record real model, Skill, MCP and cancellation acceptance plus the frontend handoff. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MCP initialized and listed tools, but its CLI could not execute Workspace reads: it omitted the persisted root and Session binding, and sent an outdated Gateway payload. Real model acceptance also found a dynamic MCP schema without an object root and a Thread continuation that advanced past a pending approval. Connect the existing contracts and stop at the approval boundary so a reviewed call can resume through the normal HTTP decision endpoint.
Add focused regressions and record the backend acceptance and frontend handoff in
docs/acceptance/2026-10-05-core-integrations.md. The report distinguishes working native Skill directory/snapshot imports from the remaining ordinary native ZIP upload gap and documents Thread, transcript and approval semantics.Validation: CLI build; focused MCP subprocess/protocol, schema and Thread approval tests; real DeepSeek calls through HTTP Thread → Skill and HTTP Thread → approval → MCP; cancellation, request replay, API restart, and Skill/MCP lifecycle checks in isolated homes. No full local test-suite rerun.