Repository navigation
test: simplify historical migration fixtures - #248
Merged
Merged
Conversation
Use the existing historical database fixture directly, remove its redundant wrapper, and replace repeated prefix initialization. Start the v135 and legacy v138 upgrade tests at their required historical versions while preserving seeded upgrade and migration-engine assertions. Co-authored-by: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store migration tests repeated database setup and wrapped an existing historical fixture with duplicate checks. Reuse
openHistoricalTestDatabasethroughout the affected tests, removeopenHistoricalMigrationFixture, and replace hand-written prefix setup with independently copied historical databases. The v135 and legacy v138 tests now start at v134 and v136 directly.Upgrade data, constraints, rejection and recovery assertions are preserved. Production migration SQL and the independent raw-migration oracles are unchanged. CONTRIBUTING now documents which fixture to use.
Based on #247 (which follows #246), so this diff contains only the migration-test cleanup.
Validation
internal/storevalidation on Windows with Go 1.26.6: all 128 selected top-level tests passed, covering affected upgrade tests, shared fixture callers and existing database-isolation contracts.-count=1 -timeout=15m; all passed in 251.228 seconds.git diff --checkpassed.Surface governance
Audit