Repository navigation
Universal Code A16 terminal authorization and A14/A15 recovery follow-ups - #238
Closed
NanaseInori wants to merge 31 commits into
Closed
NanaseInori wants to merge 31 commits into
NanaseInori wants to merge 31 commits into
Conversation
…iversal-code-a-skills-plugins-20261002
…iversal-code-a-skills-plugins-20261002
…iversal-code-a-skills-plugins-20261002
…iversal-code-a-skills-plugins-20261002 # Conflicts: # web/src/v2/components/permission-control.tsx
(cherry picked from commit 909352e)
…iversal-code-a-skills-plugins-20261002
…iversal-code-a-skills-plugins-20261002
Preserve all unrelated C work; integrate the exact six reviewed A14 blobs. (cherry picked from commit 71a08d9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current v2 Full preferences previously failed the native user-terminal path because it still required legacy Debug permission. A16 requires explicit process-local Full activation, retains Code/Local/Debug interaction and user confirmation, and checks shared authorization at native start, input and resize. Exact bindings and runtime epoch/generation prevent revoked or cold authority from reviving an old session; legacy Debug records remain readable and revocable.
Review scope and frozen references
codex/uc-b12-review-699f26c0, frozen at699f26c0329805658806f060d155c4f8e9486795.6355b865a9f108c5074119237cae4dc97c805f74; tree:3d553f9a326f8d69c0c332a520d4096c075d420f.0dd06ca1324a7b52f1c401c8249b83dbf8e0c1c4→6355b865a9f108c5074119237cae4dc97c805f74(+903/-164). Review only A16.A16 implementation and retired entry points
PolicyAuthorizerthrough the new host-onlyterminal.StartRequest.Authorizerfield. The resolver reloads current Run, workspace, mode, profile, interaction, permission and runtime activation; the field is excluded from JSON.Manager.ReconcileBindings(ctx)closes invalid sessions and revokes their leases; the existing Run-wide termination revocation remains. Cancelling one input request does not revoke an otherwise valid user-owned session.Verification and remaining work
internal/terminalandinternal/executionauth.internal/app,internal/desktopandinternal/sandbox: compile-only passed. Their test binaries and ACLTestMainfunctions were not executed.Draft review checkpoint: A16 has not yet been personally reviewed by dot. Keep C integration blocked until dot approves the actual diff. Do not mark ready or merge.