Repository navigation
B13: recheck live Sandbox budgets in schema v182 - #236
Closed
NanaseInori wants to merge 2 commits into
Closed
NanaseInori wants to merge 2 commits into
NanaseInori wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2026-10-14 完成与整理记录
已被 PR #239 完整集成。冻结 head
ca5de69b已是 main 的祖先,当前分支无待合入差异;v182 live-budget 和历史 fixture 实现均保留。关闭此重复草稿。核对版本:
main@88a7ba86。以下保留原问题/PR 说明。Supervisor wait can legitimately increase a live Sandbox candidate's recorded usage, but the existing SQL triggers reject that increase because they require the original snapshot to equal current usage. Schema v182 checks current transaction usage under the exact active Run lease, preserves equality for quiescent candidates, rejects counter rollback and exhaustion, and derives Docker admission limits from the current remaining budget.
This is a stacked draft depending on the unmerged B12 PR #235. Its base is the frozen
codex/uc-b12-review-699f26c0branch; this publication does not change #235 or main. The review delta is exactly two commits and eight files (+1047/-181):699f26c0329805658806f060d155c4f8e9486795.e4f5a2bb70c4450cacb7a4d504bb539a716a2718.ca5de69b5a7b464dc85411c5993f8d2de4d8db72.4ef8dc32f4d90c0cd6be1cfa194322082c6239de.The migration replaces the frozen-usage budget predicates in the eight existing insert triggers for candidate, disabled execution, preflight, backend evidence, output simulation, Docker observation, container plan and product admission. Historical v1–v181 migration checksums, existing rows and row identities, exact lease/cancellation/permission bindings, immutable records and recovery paths remain. No tables or second Run/Session store are added. The clean-install baseline and migration ledger are updated.
The separate test commit changes only
internal/store/clean_install_baseline_test.go(+39/-2). It seeds a genuine v132 Run with the existing historical-permission helper and reuses browser identity metadata from an isolated fixture. The v131/v132 migration test files are unchanged; the separate C-owned v132 prefix work is not overwritten.Targeted Windows race validation:
TestSchemaV131PreservesV130StreamToolIdentities,migration_v131_test.go:33, fails while preparing schema-v130 data, before the upgrade, withRun execution permission binding or transition is invalid. That file remains under separate C work. The expanded Store group was not rerun after the isolated v132 fixture fix.Frozen core Go/SQL/test bytes match the recorded tested source hashes. These checks use controlled Docker observation/transport fixtures with real SQLite, Git, Supervisor and native authority paths. No real Docker daemon, OS isolation or paid provider acceptance was performed, and the full repository/platform suite was not run. Raw logs, evidence archives and extra WIP are excluded from this publication.
Draft for dot's complete diff review. Dot has not yet reviewed B13; CI and remaining integration failures are not resolved by this checkpoint. Do not mark ready or merge, and do not treat this as independently mergeable while #235 remains unmerged.