fix(franca): use double-quoted strings in allowed value output - #525
Merged
Merged
Conversation
The allowed field was serialised using Python's list repr, producing single-quoted strings like ['January', 'February']. Non-string values such as integers and floats were unaffected, but string values with embedded spaces (e.g. 'Park Brake') would appear unquoted in the downstream Franca parser's view once the outer list brackets are stripped. Emit string elements as "value" (double-quoted) and leave numeric elements as bare literals, matching the JSON-like style used elsewhere in the Franca output. Update expected.franca for test_allowed accordingly. Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
erikbosch
approved these changes
May 29, 2026
erikbosch
left a comment
erikbosch
left a comment
Collaborator
There was a problem hiding this comment.
LGTM.
Just a bit curious - do you have an interest in keeping Franca or was this just a regression you noticed when running "all" exporters.
Contributor
Author
|
Just a passing regression.
…On Fri, 29 May 2026 at 00:23, Erik Jaegervall (Jägervall) < ***@***.***> wrote:
***@***.**** approved this pull request.
LGTM.
Just a bit curious - do you have an interest in keeping Franca or was this
just a regression you noticed when running "all" exporters.
—
Reply to this email directly, view it on GitHub
<#525?email_source=notifications&email_token=ALKX4MZPBWEO6XFNSBHHTIT45FCHRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZYG44TANRWGQ2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4387906644>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALKX4MYBMYHTEBFFU36RS5345FCHRAVCNFSM6AAAAACZJZZSMGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHM2DGOBXHEYDMNRUGQ>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/ALKX4M5J2OZJM33FIVHIT5T45FCHRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZYG44TANRWGQ2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG>
and Android
<https://github.com/notifications/mobile/android/ALKX4M6AWNUVKYP5IOWINHT45FCHRA5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTIMZYG44TANRWGQ2KM4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>.
Download it today!
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
ali-momin12
pushed a commit
to ali-momin12/vss-tools
that referenced
this pull request
Jun 15, 2026
…A#525) The allowed field was serialised using Python's list repr, producing single-quoted strings like ['January', 'February']. Non-string values such as integers and floats were unaffected, but string values with embedded spaces (e.g. 'Park Brake') would appear unquoted in the downstream Franca parser's view once the outer list brackets are stripped. Emit string elements as "value" (double-quoted) and leave numeric elements as bare literals, matching the JSON-like style used elsewhere in the Franca output. Update expected.franca for test_allowed accordingly. Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
ali-momin12
pushed a commit
to ali-momin12/vss-tools
that referenced
this pull request
Jun 16, 2026
…A#525) The allowed field was serialised using Python's list repr, producing single-quoted strings like ['January', 'February']. Non-string values such as integers and floats were unaffected, but string values with embedded spaces (e.g. 'Park Brake') would appear unquoted in the downstream Franca parser's view once the outer list brackets are stripped. Emit string elements as "value" (double-quoted) and leave numeric elements as bare literals, matching the JSON-like style used elsewhere in the Franca output. Update expected.franca for test_allowed accordingly. Signed-off-by: Matt Jones <47545907+SoundMatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
allowedfield was emitted using Python'srepr()of the list,producing single-quoted strings like
['January', 'February']. Thisis not valid Franca IDL syntax, and for string values containing spaces
(e.g.
'Park Brake') the spaces would appear unescaped inside thedownstream parser's interpretation of the literal.
Emit string elements as
"value"(double-quoted) and leave numericelements as bare literals, which is consistent with the rest of the
Franca output.
Expected franca output updated for
test_allowedaccordingly.Note: PR #514 proposes removing this exporter; this fix applies in the
meantime.
Fixes #336 (franca side)