Repository navigation
Add free functions to initialize and finalize krepe - #65
Merged
Merged
Conversation
- add krepe::initialize and krepe::finalize - enable input reset through a cli flag instead of an argument in the ScopeGuard constructor - make reset_inputs a free function - update the test script tand CMakeLists to allow specifying replayer flags
daxmawal
reviewed
Oct 17, 2026
daxmawal
left a comment
daxmawal
left a comment
Member
There was a problem hiding this comment.
It's true that it's better to use krepe::reset_inputs() this way, thanks.
Co-authored-by: Jean-François David <jeanfrancoismanutea@gmail.com>
daxmawal
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
krepe::initialize(argc, argv)andkrepe::finalize()as an alternative to theScopeGuardto initialize krepe. I also removed the input reset argument ofScopeGuardto instead use command line flag (--kernel-replayer-enable-input-reset) and madereset_inputsa free function.Lastly, the test CMakeLists and the launcher have been updated to be able to passe flags to the replayer