Fix: don't swallow ObjectNotFoundError in _recent - #103
Merged
Merged
Conversation
psrok1
force-pushed
the
fix/dont-swallow-exc-in-recent
branch
from
September 25, 2025 15:21
5f62c76 to
c28f82c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we provide non-existent
older_than, we just receive empty iterator instead of an exception. Ifolder_thanpoints at removed object,_recentsuddenly stops iterating instead of returning an exception.Because of that behavior, client can't distinguish between empty result and failed listing attempt.
This PR removes exception swallowing from
_recentmethod.