Move trans_three and trans_compete C++ sources into a src/ folder - #53
Merged
Merged
Conversation
jimboid
approved these changes
Sep 18, 2026
jimboid
left a comment
Member
There was a problem hiding this comment.
Nicely restructuring in preparation for bringing in the complexity of a python interface. Tests are known to pass for both regression and the conda dry runs which prove the code still builds and there are no missed make strings anywhere. Please merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR noves the C++ source directories (
trans_three/,trans_compete/) into a newsrc/folder to give the repo a clearer structure ahead of adding the Pythonsistpackage and a shared header. This is a structural change only, no behaviour change.Changes
Move C++ source directories into
src/:trans_three/→src/trans_three/andtrans_compete/→src/trans_compete/Update references to the new source layout:
CMakeLists.txtinclude directories and source file lists to point atsrc/trans_threeandsrc/trans_competemaster.plto resolve the compiledqsiddexecutables via$RealBin/src/trans_three/qsiddand$RealBin/src/trans_compete/qsiddtests/conftest.pyto build and locate the executables undersrc/trans_three/src/trans_compete.gitignorebuild-artifact entries (qsidd,depend) to the newsrc/pathsdocs/source/installation.rst,docs/source/development.rst,docs/source/source-usage.rst) to reference the newsrc/paths in build and usage instructionsImpact
sistPython package to live alongside the existing C++ codeconda build conda-recipe --override-channels -c conda-forge -c bioconda: all 16 tests pass