Skip to content

chore(UI): fix various build errors - #9397

Merged
SenkJu merged 2 commits into
nextgenfrom
fix-theme-build-errors
Oct 13, 2026
Merged

SenkJu merged 2 commits into
nextgenfrom
fix-theme-build-errors

Conversation

@SenkJu

@SenkJu SenkJu commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

For some reason, certain type definitions were no longer imported. Additionally, there was a type error with nested menu subtabs.

@liquidbounce-support-bot

Copy link
Copy Markdown
Contributor

Thanks for the fix — splitting the inline prop type into a Props interface reads cleaner, and the missing import type lines look right (this is likely fallout from the Svelte bump in #8385).

One small thing on Tabs.svelte: subTabs is derived as tabs[activeTab].content and cast to SubTab[], but the Array.isArray(...) guard only exists in the markup, so the derived is evaluated outside it — tabs[activeTab]?.content as SubTab[], matching the optional chaining ActiveContent already uses, would keep it consistent (and avoids a throw on an empty tabs).

Worth confirming the full type check/build is green on nextgen after this, so nothing else dropped out of the type graph. No docs impact that I can see.


🤖 Automated support reply — a human maintainer will review if this doesn't help.

@SenkJu
SenkJu merged commit 267b3c6 into nextgen Oct 13, 2026
6 checks passed
@SenkJu
SenkJu deleted the fix-theme-build-errors branch October 13, 2026 17:01
@SenkJu SenkJu added this to the 0.42.0 milestone Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant