You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for the fix — splitting the inline prop type into a Props interface reads cleaner, and the missing import type lines look right (this is likely fallout from the Svelte bump in #8385).
One small thing on Tabs.svelte: subTabs is derived as tabs[activeTab].content and cast to SubTab[], but the Array.isArray(...) guard only exists in the markup, so the derived is evaluated outside it — tabs[activeTab]?.content as SubTab[], matching the optional chaining ActiveContent already uses, would keep it consistent (and avoids a throw on an empty tabs).
Worth confirming the full type check/build is green on nextgen after this, so nothing else dropped out of the type graph. No docs impact that I can see.
🤖 Automated support reply — a human maintainer will review if this doesn't help.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason, certain type definitions were no longer imported. Additionally, there was a type error with nested menu subtabs.