Repository navigation
fix(clickgui): cancel pending bind listeners and modifier timers - #9387
Open
c8dhjp4tyv-bit wants to merge 2 commits into
Open
c8dhjp4tyv-bit wants to merge 2 commits into
c8dhjp4tyv-bit wants to merge 2 commits into
Conversation
Contributor
|
Thanks for the contribution and for including tests that fail on the old implementation. A couple of small things a reviewer will probably bring up:
No user-facing behaviour changes, so the docs shouldn't need updating. A maintainer will do the actual review. 🤖 Automated support reply — a human maintainer will review if this doesn't help. |
Add npm test and run it after the theme build in verify-pr. Document the script-only fixture and fail clearly when its source matches need updating.
MukjepScarlet
requested review from
1zun4 and
SenkJu
and removed request for
SenkJu
October 11, 2026 08:26
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Canceling a bind after pressing a modifier leaves input listeners and its timeout alive. Restarting immediately lets the old timeout finish the new session. Successful input also leaves the unused keyboard or mouse waiter subscribed, and component destruction does not cancel these waits.
Add optional AbortSignal support to waitMatches. Give each bind session its own controller, cancel the losing waiter, and clear listeners, timers and modifier state on completion, cancellation or destruction. Guard asynchronous continuations with the session's signal.
Validation:
https://github.com/c8dhjp4tyv-bit/LiquidBounce/actions/runs/38117439329