[Praizfotos]

PR Description

This PR closes the following issues:

• closes [Contracts] #67 Split large contract lib.rs into modules #1324
• closes [Contracts] #66 Centralize TTL and storage constants #1323
• closes [Contracts] #65 Batch storage reads in market contract #1322
• closes [Contracts] #68 Untrack test_snapshots and ignore them #1325

Changes

#1324 — Split large contract lib.rs into modules

• analytics: split lib.rs (537 → 378 lines). Types moved to contracts/analytics/src/types.rs, read-only queries to contracts/analytics/src/queries.rs, inline tests to contracts/analytics/src/contract_tests.rs.
• governance: split lib.rs (624 → 381 lines). Types moved to contracts/governance/src/types.rs, upgrade-target validation to contracts/governance/src/validation_helpers.rs, legacy proposal/upgrade logic to contracts/governance/src/legacy.rs.
• Both queries.rs and legacy.rs expose plain functions; the #[contractimpl] blocks in lib.rs keep thin delegating wrappers so the contract ABI is unchanged.
• grants, certificate, badges: extracted the inline mod tests block into a separate contract_tests.rs file.
• buyback, credential_metadata, grants, certificate, badges, nft, token, registry: extracted types, storage keys, and event topic constants into a types.rs module and re-exported them from lib.rs.
• Result: every lib.rs in the workspace is now under 400 lines.

#1323 — Centralize TTL and storage constants

• Added STORAGE_TTL_THRESHOLD and STORAGE_TTL_EXTEND_TO to contracts/shared/src/constants.rs.
• Added MAX_ENTRY_TTL, MIN_PERSISTENT_ENTRY_TTL, and MIN_TEMP_ENTRY_TTL to the shared constants module.
• Replaced hardcoded TTL literals in analytics, grants, governance, registry, buyback, and credential_metadata with the shared constants.
• No TTL literal remains outside contracts/shared/src/constants.rs.

#1325 — Untrack test_snapshots and ignore them

• Added contracts/*/test_snapshots/ to .gitignore.
• Removed all previously tracked snapshot JSON files from the git index with git rm --cached -r contracts/*/test_snapshots.
• Tests still run and regenerate snapshots locally; they are now ignored by git.

#1322 — Batch storage reads in the market contract

• Added a batched read helper module at contracts/market/src/storage.rs with read_products_batch, read_purchases_batch, and read_escrows_batch.
• The batch settle and batch refund paths group their storage reads through these helpers.
• Gas cost before and after the batched path is recorded in the market test suite.

Other improvements

• registry now uses the shared STORAGE_TTL_THRESHOLD constant instead of a hardcoded 100 in the pause path.
• Event topic constants and level_ord in the registry are public so other modules can reuse them.
• Removed the now-unused paginate import from the analytics lib.rs.
• Governance's zero-address check moved to validation_helpers.rs and is shared by the legacy upgrade path.

Verification

• All lib.rs files in the workspace are under 400 lines — satisfies the [Contracts] #67 Split large contract lib.rs into modules #1324 acceptance criterion.
• TTL values live only in contracts/shared/src/constants.rs — satisfies the [Contracts] #66 Centralize TTL and storage constants #1323 acceptance criterion.
• Market contract has a batched read helper with recorded gas — satisfies the [Contracts] #65 Batch storage reads in market contract #1322 acceptance criterion.
• No snapshot file is tracked by git, and tests still run — satisfies the [Contracts] #68 Untrack test_snapshots and ignore them #1325 acceptance criterion.
• The closing keywords above will close the four linked issues automatically when this PR is merged.

Closes #1324
Closes #1323
Closes #1322
Closes #1325

[drips-wave]

@Praizfotos Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits