Repository navigation
fix: resolve issue #1367 - #1405
Closed
yachamdaniel1-alt wants to merge 1 commit into
Closed
yachamdaniel1-alt wants to merge 1 commit into
yachamdaniel1-alt wants to merge 1 commit into
Conversation
yachamdaniel1-alt
force-pushed
the
fix/issue-1367
branch
from
October 21, 2026 07:05
735a704 to
96cc171
Compare
Align the committed lock files with the manifests so both the Cargo and npm
workspaces resolve from a clean checkout.
Cargo:
- contracts/market: the dev-dependency was pinned to soroban-sdk 20.0.0 while
[dependencies] uses 21.5.0 and the workspace uses 21.7. Cargo cannot hold
both majors in one graph, so the whole workspace failed to resolve with an
ed25519-dalek conflict. Align it to 21.5.0.
- contracts/market: restore the proptest dev-dependency. contracts/market/src/
fuzz_tests.rs uses proptest and Cargo.lock already listed it, but the manifest
had lost the entry.
- Cargo.lock: add the missing brain-storm-grants entry for brain-storm-integration,
which its manifest declares but the lock omitted.
npm:
- package-lock.json: the committed lock was stale relative to package.json, so
'npm ci' refused to run ('package.json and package-lock.json are not in
sync'). packages/api was absent from the lock entirely and lint-staged and a
number of transitive dependencies were missing. Regenerate the lock.
contracts/shared:
- remove the duplicated 'pub mod access;' declaration, which prevented the
crate from compiling and so prevented the lock fix from being validated.
cargo metadata --locked and npm ci now both succeed.
Closes BrainTease#1367
yachamdaniel1-alt
force-pushed
the
fix/issue-1367
branch
from
October 21, 2026 07:09
96cc171 to
db7dd27
Compare
Contributor
Author
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1367